Handle deletion of coach from the assigned classes #13652
Conversation
github-actions
bot
added
APP: Facility
Build Artifacts
|
AllanOXDi
force-pushed
the
handle-deleting-of-coach-from-all-sections
branch
from
f984581 to
b67fd5c
Compare
AllanOXDi
force-pushed
the
handle-deleting-of-coach-from-all-sections
branch
from
b67fd5c to
af89b9c
Compare
AllanOXDi
changed the title
There was a problem hiding this comment.
The issue reported in #13640 should be resolved by ensuring the data populating the classes page does not get populated using soft-deleted users.
We don't want to delete any of the user's relationships to other things when they're soft-deleted, only when they're hard-deleted.
The main reason for this is that restoring a user to their former glory wouldn't be viable any longer.
I think that this is likely the best place to start looking where the Classroom is consolidating it's response. Seems like we could do some filtering there to exclude soft-deleted users.
AllanOXDi
force-pushed
the
handle-deleting-of-coach-from-all-sections
branch
from
af89b9c to
00c96cd
Compare
github-actions
bot
added
the
DEV: backend
There was a problem hiding this comment.
Code changes look good overall - let's get @pcenov 's eyes on it before dismissing my review and approving
There was a problem hiding this comment.
Thanks @AllanOXDi and @nucleogenesis, LGTM - removed coaches, admins and super admins are now also removed from the class and can be restored.
nucleogenesis
dismissed
their stale review
Feedback has been resolved, QA has passed <3
3 participants
Summary
Fixes coaches and admins that remain assigned to a class after being deleted.
rec.mov
References
close #13640
Reviewer guidance
Assign coaches, admins and super admins to a class or several classes and then delete them
Please note: If you attempt to perform bulk delete, you will be hit by
503which should be gracefully handled in #13614