Fixes wrong accent colors #1492
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
themes
Nuklon
commented
Jul 17, 2025
Comment on lines
+337
to
+344
| UiApplication.Current.Resources["SystemAccentBrush"] = systemAccent.ToBrush(); | ||
| UiApplication.Current.Resources["SystemFillColorAttentionBrush"] = secondaryAccent.ToBrush(); | ||
| UiApplication.Current.Resources["AccentTextFillColorPrimaryBrush"] = tertiaryAccent.ToBrush(); | ||
|
|
||
| UiApplication.Current.Resources["AccentTextFillColorPrimaryBrush"] = secondaryAccent.ToBrush(); | ||
| UiApplication.Current.Resources["AccentTextFillColorSecondaryBrush"] = tertiaryAccent.ToBrush(); | ||
| UiApplication.Current.Resources["AccentTextFillColorTertiaryBrush"] = secondaryAccent.ToBrush(); | ||
| UiApplication.Current.Resources["AccentFillColorSelectedTextBackgroundBrush"] = | ||
| systemAccent.ToBrush(); | ||
| UiApplication.Current.Resources["AccentFillColorDefaultBrush"] = secondaryAccent.ToBrush(); | ||
| UiApplication.Current.Resources["AccentTextFillColorTertiaryBrush"] = primaryAccent.ToBrush(); | ||
|
|
||
| UiApplication.Current.Resources["AccentFillColorSelectedTextBackgroundBrush"] = systemAccent.ToBrush(); |
There was a problem hiding this comment.
These were set all wrong. I've corrected them as per https://github.com/microsoft/microsoft-ui-xaml/blob/main/src/controls/dev/CommonStyles/Common_themeresources_any.xaml.
Nuklon
commented
Jul 17, 2025
| @@ -8,16 +8,16 @@ | |||
| <ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"> | |||
|
|
|||
| <!-- Colors depending on the theme should be changed by the Manager --> | |||
| <Color x:Key="SystemAccentColor">#3379d9</Color> | |||
| <Color x:Key="SystemAccentColor">#0078d4</Color> | |||
There was a problem hiding this comment.
This is based on Windows' Blue default accent color.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
The current brushes are all wrong and don't match with WinUI:
Fixes: #1481
What is the new behavior?
Gets the correct brushes from Windows. I also improved the fallback colors (still not perfect, but better).
WinUI gallery original colors (now WPF-UI has the same colors):
