Move //revocation/reasons.go into the post-OCSP world #8355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
force-pushed
the
rm-akamai-purger
branch
from
af627a0 to
e9e77d1
Compare
aarongable
force-pushed
the
admin-reason-string
branch
from
630de0d to
df23748
Compare
jprenken
previously approved these changes
Sep 11, 2025
jprenken
requested review from
a team and
jsha
and removed request for
a team
jprenken
approved these changes
Sep 11, 2025
jsha
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define the acceptable revocation reason codes directly in our
revocationpackage. Make the int-to-string and string-to-int conversion capabilities into immutable functions, rather than ad-hoc dictionary lookups. Do the same for the user- or admin-allowed reasons. These changes make the revocation package wholly standalone, with no dependencies (except fmt).Update all of our logic and tests to use revocation.Reasons instead of constants from the /x/crypto/ocsp package. This removes all reliance on the /x/crypto/ocsp package for revocation reasons, which felt awkward in a CRLs-only world.
Finally, take advantage of the improvements above to give the ceremony CRL tool the ability to take revocation reasons as strings, rather than integers. This behavior matches the capabilities already present in the admin revoke-cert tool
Fixes #8328
Warning
Do not merge before #8351