Skip to content

Conversation

jprenken
Copy link
Contributor

@jprenken jprenken commented Sep 9, 2025

Fixes #8334

@jprenken jprenken marked this pull request as ready for review September 9, 2025 04:08
@jprenken jprenken requested a review from a team as a code owner September 9, 2025 04:08
@jprenken
Copy link
Contributor Author

jprenken commented Sep 9, 2025

I ran this new release workflow on a forked repo, with the GitHub account name changed.

Copy link
Member

@beautifulentropy beautifulentropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #7891 we began building and publishing a container for ct-test-srv. Since then, we’ve updated this container and we're now tagging and uploading it as a Boulder container as well.

If we’re shipping the same container to different repositories:

  1. We should consider adding a TODO to remove the ct-test-srv push so we’re (eventually) not pushing two identical artifacts to different repos, and
  2. we might also want to rename these steps to make it clearer that we’re building a Boulder container and pushing it as both Boulder and ct-test-srv.

aarongable
aarongable previously approved these changes Sep 10, 2025
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since then, we’ve updated this container and we're now tagging and uploading it as a Boulder container as well.

I don't think that's what's happening here? The boulder container is built on line 36 using container-build.sh; the ct-test-srv container is built on line 61 via direct invocation of docker buildx build. It's is a little spooky action at a distance that "docker push" pushes the right container image to the right repository just given a string name, but the two pushes on lines 69 and 72 are pushing different things to different places.

@beautifulentropy
Copy link
Member

I don't think that's what's happening here? The boulder container is built on line 36 using container-build.sh; the ct-test-srv container is built on line 61 via direct invocation of docker buildx build. It's is a little spooky action at a distance that "docker push" pushes the right container image to the right repository just given a string name, but the two pushes on lines 69 and 72 are pushing different things to different places.

Thanks for clarifying, Aaron. We could make this relationship a lot clearer by changing the step name on line 33 from "Build .deb" to "Build boulder container and .deb". We should also update this line at the same time or in a follow up PR.

@jprenken jprenken merged commit a2d4e70 into main Sep 11, 2025
12 checks passed
@jprenken jprenken deleted the ghcr branch September 11, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload Boulder minimal container image as part of release process
3 participants