-
-
Notifications
You must be signed in to change notification settings - Fork 627
Upload releases to GHCR #8386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload releases to GHCR #8386
Conversation
I ran this new release workflow on a forked repo, with the GitHub account name changed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #7891 we began building and publishing a container for ct-test-srv. Since then, we’ve updated this container and we're now tagging and uploading it as a Boulder container as well.
If we’re shipping the same container to different repositories:
- We should consider adding a TODO to remove the ct-test-srv push so we’re (eventually) not pushing two identical artifacts to different repos, and
- we might also want to rename these steps to make it clearer that we’re building a Boulder container and pushing it as both Boulder and ct-test-srv.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since then, we’ve updated this container and we're now tagging and uploading it as a Boulder container as well.
I don't think that's what's happening here? The boulder container is built on line 36 using container-build.sh
; the ct-test-srv container is built on line 61 via direct invocation of docker buildx build
. It's is a little spooky action at a distance that "docker push" pushes the right container image to the right repository just given a string name, but the two pushes on lines 69 and 72 are pushing different things to different places.
Thanks for clarifying, Aaron. We could make this relationship a lot clearer by changing the step name on line |
Fixes #8334