kubevirt: Fix cluster volume replica reporting, skip not fully created. #5189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KubeClusterInfo: skip replicas without ownerid, inst mgr, and image, wait until creation completes. Signed-off-by: Andrew Durbin <[email protected]>
github-actions
bot
requested review from
eriknordmark,
naiming-zededa and
zedi-pramodh
Just waiting for CI checks (yetus, ...) to complete successfully before marking ready for review. |
rene
reviewed
Aug 20, 2025
| @@ -147,6 +147,11 @@ func populateKVIFromPVCName(kvi *types.KubeVolumeInfo) (*types.KubeVolumeInfo, e | |||
| onlineReps := 0 | |||
| consistentReps := 0 | |||
| for _, lhReplica := range replicas.Items { | |||
| if (lhReplica.Status.OwnerID == "") && (lhReplica.Status.InstanceManagerName == "") && (lhReplica.Status.CurrentImage == "") { | |||
There was a problem hiding this comment.
shouldn't you skip if any of these fields are missing? Or it's OK to have only some of them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
KubeClusterInfo: skip replicas without ownerid,
inst mgr, and image, wait until creation completes.
Some failure modes can show temporarily large replica counts for replicas
which have not completed creation.
PR dependencies
None
How to test and validate this PR
Changelog notes
None
PR Backports
TBD
Checklist
I've provided a proper description
I've added the proper documentation
I've tested my PR on amd64 device
I've tested my PR on arm64 device
I've written the test verification instructions
I've set the proper labels to this PR
I've checked the boxes above, or I've provided a good reason why I didn't
check them.