Add initial Eclipse attack simulation module with metrics collection #950

Fatumayattani · 2025-09-23T11:25:01Z

What was wrong?

This PR implements the initial setup for the Network Attack Simulation module in py-libp2p, as discussed in [[Discussion #929]] and tracked under Issue #57. The primary focus is on Eclipse attack simulation, building the test network, simulating malicious peers, and establishing the framework for network attack testing.

How was it fixed?

Added tests/security/attack_simulation/ submodule containing:

Eclipse attack:
- malicious_peer.py – Simulates malicious peer behavior
- network_builder.py – Builds test networks with honest and malicious nodes
- metrics_collector.py – Collects attack metrics during simulation
- attack_scenarios.py – Defines different Eclipse attack scenarios
- test_eclipse_simulation.py – Test suite validating network setup and malicious behavior
Utilities:
- Metrics calculation (attack_metrics.py)
- Network monitoring (network_monitor.py)
- Peer behavior simulation (peer_behavior_simulator.py)
- Tests for utilities
Configuration:
- attack_configs.py – Attack configuration options
- network_topologies.py – Predefined network topologies
Added README.md documenting module overview, structure, setup, usage, testing, metrics, roadmap, and Eclipse attack flow (Mermaid diagram)
All tests pass locally (6/6) confirming:
- Network setup works as expected
- Malicious peer behaviors execute correctly
- Metrics collection framework functions properly

To-Do

Clean up commit history if necessary
Add or update documentation related to these changes

Cute Animal Picture

…TLS docs

seetadev · 2025-09-23T15:40:27Z

@Fatumayattani : Thank you for opening the PR on eclipse attack simulation.

Great effort indeed. CCing @acul71, @yashksaini-coder, @bomanaps for their thoughts and feedback. This PR will indeed impact the py-libp2p library.

There is one CI/CD issue too, which is not related to your pull request.

I investigated it and documented it at #949 .

@yashksaini-coder , @sumanjeet0012 and @acul71 are fixing it. We will soon have all the CI/CD tests passing.

@Fatumayattani : Will re-run CI/CD pipeline once the issue is fixed today or tomorrow. In the meantime, assigning you more projects and issues on py-libp2p.

yashksaini-coder · 2025-09-23T19:45:35Z

@Fatumayattani can I get the access for this ?

Fatumayattani · 2025-09-24T06:27:55Z

Thank you @seetadev for the review and for coordinating on the CI/CD issue. I’ll re-run the checks once that’s resolved.

@yashksaini-coder I’ve added you as a collaborator so you now have access to the feature/attack-simulation branch. Please let me know if you face any issues or need anything else to get started.

Really appreciate everyone’s feedback and support in pushing this forward.

…ation files

yashksaini-coder · 2025-09-24T15:13:27Z

@Fatumayattani @seetadev Hi, I've reviewed the PR, and executed the checks and all tests on my end. Everything is good, all test cases passed ✔️ and some new changes to fix the linting and minor errors.

I will work on this for adding more attack simulation and review

…simulation

seetadev · 2025-09-24T17:55:25Z

@Fatumayattani , @yashksaini-coder : Wonderful, great to hear. Appreciate your efforts.

We will review this PR in detail. Re-ran the CI/CD pipeline.

Since, it is an important module addition, wish to have feedback first from @acul71 , @lla-dane and @sumanjeet0012 .

We will discuss with @pacrob and have his review after discussing in tomorrow's maintainer's call.

acul71

PR #950 Review: Eclipse Attack Simulation Module

Summary

This PR introduces a Network Attack Simulation module for py-libp2p with a well-designed dual-layer architecture for Eclipse attack testing.

Recommendation: ✅ APPROVE with mods

Implementation Analysis

✅ What's Working Well:

Dual-layer architecture - Simulation + Real integration
Real integration tests - 3/3 tests pass with actual libp2p hosts
Comprehensive framework - Well-structured attack simulation foundation
Test coverage - 9/9 tests pass (6 simulation + 3 real integration)

✅ Architecture Design:

Simulation Layer: Fast framework validation with placeholder metrics (by design)
Real Integration Layer: Comprehensive attack simulation with actual libp2p components

Current Assessment

Test Coverage: 100% (9/9 tests pass)
Code Quality: Excellent structure with real integration
Documentation: Comprehensive README with clear usage examples
Performance: Fast simulation (0.40s) + Real integration (2.06s)
Functionality: ✅ COMPLETE - Both layers working as designed

Final Recommendation

✅ APPROVE but answer questions
and also wait is there a newsfragment?

(venv) luca@r17:~/PNL_Launchpad_Curriculum/Libp2p/py-libp2p$ l newsfragments/57
ls: cannot access 'newsfragments/57': No such file or directory

acul71 · 2025-09-24T20:33:43Z

tests/security/attack_simulation/README.md

+1. [Metrics and Analysis](#metrics-and-analysis)
+1. [Roadmap](#roadmap)
+1. [Eclipse Attack Flow](#eclipse-attack-flow)
+1. [Contributing](#contributing)


Why are all this 1s here not 1,2,3,....

Just noticed the auto-tab completion

acul71 · 2025-09-24T20:34:59Z

tests/security/attack_simulation/config/attack_configs.py

+    "honest_nodes": 10,
+    "malicious_nodes": 3,
+    "attack_intensity": 0.5,
+}


Did you try with different settings? are them handled ?

Some logs with different settings?
You may want to open a discussion page, and only put a link here, to not over bloat the PR

I will try with different settings and have the screenshot of the results in the Discussion page for this.

@acul71 I have done some more attack simulation test with multiple configs, and new test suite, shared the new disucssion here, #960

…lation' into feature/attack-simulation

for improved clarity and maintainability

…tack simulation

…store result as json

Fatumayattani · 2025-09-26T07:15:19Z

Thanks everyone for the feedback and contributions.

I’ve added the missing newsfragment.

Kudos to @yashksaini-coder for running additional tests, and Discussion #960 contains the comprehensive Eclipse attack simulation results.

Special thanks to @acul71 for the detailed review and @seetadev for coordinating the CI/CD workflow. Really appreciate everyone’s collaboration and support on this.

pacrob · 2025-10-05T16:54:19Z

tests/security/attack_simulation/eclipse_attack/metrics_collector.py

@@ -0,0 +1,171 @@
+class AttackMetrics:


This class is duplicated in utils/attack_metrics.py.

Thanks @pacrob , I’ve removed the duplicate and now import AttackMetrics from utils/attack_metrics.py.

pacrob · 2025-10-05T17:34:29Z

tests/security/attack_simulation/eclipse_attack/test_multiple_scenarios.py

+            std_dev = variance**0.5
+            consistency_ratio = std_dev / mean_score if mean_score > 0 else 0
+
+            print(".2f")


Should this be here?

Removed the unnecessary print line to keep the tests clean.

pacrob · 2025-10-05T17:36:02Z

tests/security/attack_simulation/eclipse_attack/real_network_builder.py

+    async def _connect_nodes(self, hosts: list[IHost]):
+        """Connect hosts in a simple topology"""
+        # Connect each host to the next one in a ring topology
+        for i in range(len(hosts)):
+            # Each node connects to 2 neighbors
+            for j in range(i + 1, min(i + 3, len(hosts))):
+                try:
+                    peer_info = PeerInfo(hosts[j].get_id(), hosts[j].get_addrs())
+                    await hosts[i].connect(peer_info)
+                    await trio.sleep(0.1)  # Allow connection to establish
+                except Exception as e:
+                    print(f"Connection failed between {i} and {j}: {e}")


This function doesn't appear to be used anywhere.

Appreciate the note 🙏 we’re keeping this function for Phase 2 as it’ll be used in the topology and interop tests.

pacrob · 2025-10-05T17:44:54Z

In general, I'm concerned about the huge amount of emojis and print statements in the new tests. In the current state, these just clutter up CI/logs. Consider converting them to logging statements.

yashksaini-coder · 2025-10-05T17:47:01Z

let me work on it, @pacrob

seetadev · 2025-10-06T09:05:36Z

@yashksaini-coder and @Fatumayattani : Thank you Yash for the initiative. Very important set of feedback points shared by @pacrob. CCing @acul71 to keep him in the loop of this PR.

@pacrob : Thank you for sharing pointers and feedback. Completely agree with the improvements shared on the test suite front. Appreciate your support. Me and @acul71 will get this resolved soon.

…est print

Fatumayattani · 2025-10-06T12:08:51Z

Thank you @pacrob 🙏 for the clear and helpful feedback.
@yashksaini-coder let me know if you need any help with the fixes and logging cleanup.
Grateful to you, @seetadev, and @acul71 for all the support and encouragement.

yashksaini-coder · 2025-10-06T14:35:53Z

Thank you @pacrob 🙏 for the clear and helpful feedback. @yashksaini-coder let me know if you need any help with the fixes and logging cleanup. Grateful to you, @seetadev, and @acul71 for all the support and encouragement.

Appreciate it, once I get this fix up. I will ping you also we need to have a discussion post for this.

…for reliability

…d clean up whitespace

pacrob · 2025-10-06T15:30:27Z

tests/security/attack_simulation/README.md

+pytest tests/security/attack_simulation/test_eclipse_attack.py -v
+pytest tests/security/attack_simulation/test_sybil_attack.py -v
+pytest tests/security/attack_simulation/test_flooding_attack.py -v
+pytest tests/security/attack_simulation/test_connection_exhaustion.py -v
+pytest tests/security/attack_simulation/test_protocol_attack.py -v
+pytest tests/security/attack_simulation/test_attack_analysis.py -v


Please review these and other files referenced in this README - many of them don't exist.

I have removed as this was a previous stage change, no longer adding this.

…etrics collector

yashksaini-coder · 2025-10-07T16:10:40Z

@seetadev Requesting a CI/CD run all test cases and review have been addressed. Update the docs and refactoring done.

seetadev · 2025-10-08T13:31:47Z

@yashksaini-coder : Thank you so much to you and @Fatumayattani for your efforts. Appreciate it.

It took me sometime to reach this PR as there were close to 12+ PRs in the review queue. Did re-run the CI/CD pipeline and all the test cases are passing.

This PR is looking good. Doing a thorough review today. Also, asking @acul71 to do a peer review on this PR and share feedback points and improvements.

We will discuss this with @pacrob tomorrow before doing a final review + merge, once all the improvements are addressed.

Fatumayattani · 2025-10-09T06:18:37Z

Thank you @seetadev 🙏
Appreciate you taking the time to review this. Glad to hear the tests passed. Thank you to @yashksaini-coder for collaborating on this. Looking forward to any feedback from @acul71 and @pacrob .

Fatumayattani · 2025-10-21T11:58:47Z

Hi everyone 👋

Added two new attack simulation scenarios: Replay Attack and Routing Poisoning Attack.

They’re organized under tests/security/attack_simulation/ to keep everything consistent with the existing structure.

Also included a short screencast showing the tests running successfully.

replay.mp4

Appreciate any feedback or suggestions from the team.

cc @seetadev @acul71 @pacrob @yashksaini-coder

seetadev · 2025-10-22T15:08:26Z

@Fatumayattani , @yashksaini-coder : Appreciate the efforts. Re-ran the CI/CD pipeline.

Wish to share that we received some nice pointers from friends at FIL-oz and Polkadot: please visit #929 (comment)

…trics - Introduced new attack types: Bootnode Poisoning, Long-Range Fork Replay, Invalid Block Propagation, and Finality Stall. - Updated README to reflect new features and configurations. - Added comprehensive mitigation strategies documentation. - Enhanced attack metrics to include new metrics for the extended threat model. - Improved configuration options for new attack types in `attack_configs.py`. - Refactored existing code for better readability and maintainability.

Fatumayattani and others added 11 commits August 15, 2025 10:12

tls support

7a6b530

update tls docs

d0345b6

update tls support

7dd3469

update changes

bfbc389

tls support

a9b510e

tls support doc libp2p#700

6ea3016

Add tls-support.rst to docs toctree

77f4764

Merge branch 'main' into main

cc68f63

Replace asyncio with trio, fix newline, and run pre-commit checks on …

73d44ed

…TLS docs

Add initial Eclipse attack simulation module with tests

4f9eabe

Merge branch 'main' into feature/attack-simulation

d801a91

yashksaini-coder and others added 3 commits September 24, 2025 12:11

Merge branch 'libp2p:main' into feature/attack-simulation

c1df722

Merge branch 'main' into feature/attack-simulation

5691e6e

Refactor code for consistency and clarity; update README and configur…

6312c95

…ation files

Add real integration tests and metrics collection for Eclipse attack …

999d293

…simulation

acul71 approved these changes Sep 24, 2025

View reviewed changes

yashksaini-coder and others added 8 commits September 25, 2025 13:14

Merge branch 'main' into feature/attack-simulation

b46cdef

Linting errors resolved

44044f8

Merge remote-tracking branch 'refs/remotes/origin/feature/attack-simu…

efffe92

…lation' into feature/attack-simulation

Refactor real metrics collector and test structure

ba04a4f

for improved clarity and maintainability

Remove non-existent file

32483ac

Enhance type annotations and improve metrics collection in Eclipse at…

16708e3

…tack simulation

performed more test and test suite for multiple config scenarios and …

fd4d578

…store result as json

add newsfragment for PR libp2p#950 (Eclipse attack simulation module)

7004d94

yashksaini-coder and others added 3 commits October 4, 2025 12:20

Merge branch 'main' into feature/attack-simulation

587aa6f

Merge branch 'main' into feature/attack-simulation

6b3a421

Merge branch 'main' into feature/attack-simulation

d9e51e9

pacrob reviewed Oct 5, 2025

View reviewed changes

Merge branch 'main' into feature/attack-simulation

f437fcf

Address pacrob feedback: remove duplicate AttackMetrics and cleanup t…

4c36e6c

…est print

yashksaini-coder added 2 commits October 6, 2025 20:36

refactor: improve temporary file handling and reduce test peer count …

8d9e7c8

…for reliability

refactor: standardize list type annotations in AttackMetrics class an…

003f4e5

…d clean up whitespace

pacrob reviewed Oct 6, 2025

View reviewed changes

yashksaini-coder and others added 3 commits October 6, 2025 21:12

Merge branch 'main' into feature/attack-simulation

0f81749

update README

8ef6ebf

fix: correct whitespace in README and improve comment formatting in m…

8b9c4b4

…etrics collector

yashksaini-coder and others added 3 commits October 10, 2025 17:35

Merge branch 'main' into feature/attack-simulation

f61574e

Merge branch 'libp2p:main' into feature/attack-simulation

1a5d9a9

test: add replay and routing_poisoning attack simulations

7777dd2

Merge branch 'main' into feature/attack-simulation

8bb588c

yashksaini-coder and others added 2 commits October 23, 2025 20:29

Merge branch 'main' into feature/attack-simulation

0838067

Add initial Eclipse attack simulation module with metrics collection #950

Are you sure you want to change the base?

Add initial Eclipse attack simulation module with metrics collection #950

Uh oh!

Conversation

Fatumayattani commented Sep 23, 2025

What was wrong?

How was it fixed?

To-Do

Cute Animal Picture

Uh oh!

seetadev commented Sep 23, 2025

Uh oh!

yashksaini-coder commented Sep 23, 2025

Uh oh!

Fatumayattani commented Sep 24, 2025

Uh oh!

yashksaini-coder commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seetadev commented Sep 24, 2025

Uh oh!

acul71 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

PR #950 Review: Eclipse Attack Simulation Module

Summary

Implementation Analysis

✅ What's Working Well:

✅ Architecture Design:

Current Assessment

Final Recommendation

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Fatumayattani commented Sep 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pacrob commented Oct 5, 2025

Uh oh!

yashksaini-coder commented Oct 5, 2025

Uh oh!

seetadev commented Oct 6, 2025

Uh oh!

Fatumayattani commented Oct 6, 2025

Uh oh!

yashksaini-coder commented Oct 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yashksaini-coder commented Oct 7, 2025

Uh oh!

seetadev commented Oct 8, 2025

Uh oh!

Fatumayattani commented Oct 9, 2025

Uh oh!

Fatumayattani commented Oct 21, 2025

yashksaini-coder commented Sep 24, 2025 •

edited

Loading

acul71 left a comment •

edited

Loading