Skip to content

Conversation

simsonraj
Copy link

This PR implements the validation of the expected error codes for JSON RPC responses.
The extension of JSON-RPC spec with error codes & grouping can be found here

@sambacha
Copy link

this doesn't implement anything and you should feel bad

@zcstarr
Copy link
Contributor

zcstarr commented May 28, 2025

@sambacha it seems you haven't read the PR or the issue, across clients we do not have great standard errors , which means you can't effectively test well across clients. This has hamstrung client devs for years, besu doesn't respond the same as nethermind doesn't respond the same as geth. In fact there aren't even good guidelines on how error codes get expanded. This PR represents a tangible way forward and is not autogen'd or anything, in fact is the culmination of months, and almost a year of work.

This is rude to comment on repos without asking questions about the issue first. If you have a complaint about the PRs or issue, I implore you to synthesize your thoughts or criticisms of it and put that here, but don't try and deter people from even reading the PR or evaluating it on the merits of it's contribution.

Please be respectful of the hardwork people are putting in to make the ecosystem better, for the entire Ethereum ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants