feat: introduce propose change tool template #17164

tatianainama · 2025-10-01T13:45:22Z

Description:

This PR adds a UI component to display proposed changes tool calls in the UI.

Created a new AiProposeChangeToolCall component to render proposed changes
Implemented renderers for different entity types (table, dimension, metric)
Added support for displaying field operations (currently only 'replace')
Added storybook stories file to test multiple variants of the component without the need to prompt ai

tatianainama · 2025-10-01T13:45:39Z

refactor: create ToolCallPaper component #17188
feat: introduce propose change tool template #17164 👈 (View in Graphite)
feat: add propose change tool validators #17163
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-10-01T13:48:05Z

Your preview environment pr-17164 has been deployed with errors.

github-actions · 2025-10-01T15:19:18Z

Preview environment logs can be accessed at: https://console.cloud.google.com/logs/query;query=resource.labels.namespace_name%3D%22pr-17164%22;duration=PT30M?project=lightdash-previews

github-actions · 2025-10-01T15:19:18Z

You can ssh into the preview environment by running: ./scripts/okteto-ssh.sh 17164

github-actions · 2025-10-02T07:54:21Z

Preview environment logs can be accessed at: https://console.cloud.google.com/logs/query;query=resource.labels.namespace_name%3D%22pr-17164%22;duration=PT30M?project=lightdash-previews

github-actions · 2025-10-02T07:54:21Z

You can ssh into the preview environment by running: ./scripts/okteto-ssh.sh 17164

greptile-apps

Sequence Diagram

sequenceDiagram
    participant User
    participant AssistantBubble as "AgentChatAssistantBubble"
    participant AiProposeChangeToolCall as "AiProposeChangeToolCall"
    participant ChangeRenderer as "ChangeRenderer"
    participant OperationRenderer as "OperationRenderer"
    participant SupportElements as "SupportElements"

    User->>AssistantBubble: "Views AI assistant message"
    AssistantBubble->>AssistantBubble: "Extract proposeChangeToolCall from message/stream"
    
    alt proposeChangeToolCall exists
        AssistantBubble->>AiProposeChangeToolCall: "Render tool call with change & entityTableName"
        AiProposeChangeToolCall->>AiProposeChangeToolCall: "Create collapsible container with change type badge"
        
        alt Container is expanded
            AiProposeChangeToolCall->>ChangeRenderer: "Render change based on entityType"
            
            alt entityType is 'table'
                ChangeRenderer->>SupportElements: "Render TableBreadcrumb"
                ChangeRenderer->>OperationRenderer: "Render operations for each patch field"
            else entityType is 'dimension'
                ChangeRenderer->>SupportElements: "Render FieldBreadcrumb with dimension info"
                ChangeRenderer->>OperationRenderer: "Render operations for each patch field"
            else entityType is 'metric'
                ChangeRenderer->>SupportElements: "Render FieldBreadcrumb with metric info"
                ChangeRenderer->>OperationRenderer: "Render operations for each patch field"
            end
            
            loop For each operation
                OperationRenderer->>OperationRenderer: "Render replace operation with field name and value"
            end
        end
    end

_{10 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

...ures/aiCopilot/components/ChatElements/ToolCalls/AiProposeChangeToolCall/SupportElements.tsx

github-actions · 2025-10-02T09:06:27Z

Preview environment logs can be accessed at: https://console.cloud.google.com/logs/query;query=resource.labels.namespace_name%3D%22pr-17164%22;duration=PT30M?project=lightdash-previews

github-actions · 2025-10-02T09:06:28Z

You can ssh into the preview environment by running: ./scripts/okteto-ssh.sh 17164

joaoviana · 2025-10-02T11:12:15Z

...ages/frontend/src/ee/features/aiCopilot/components/ChatElements/AgentChatAssistantBubble.tsx

+    const proposeChangeToolCall = isStreaming
+        ? (streamingState?.toolCalls.find((t) => t.toolName === 'proposeChange')
+              ?.toolArgs as ToolProposeChangeArgs)
+        : (message.toolCalls.find((t) => t.toolName === 'proposeChange')
+              ?.toolArgs as ToolProposeChangeArgs); // TODO: fix message type, it's `object` now
+


For later: find a way to avoid "as" and use Tool call zod schemas

joaoviana · 2025-10-02T11:20:19Z

packages/frontend/src/stories/AiProposeChangeToolCall.stories.tsx

@@ -0,0 +1,212 @@
+import '@mantine-8/core/styles.css';


move to stories

joaoviana · 2025-10-02T11:21:23Z

...es/aiCopilot/components/ChatElements/ToolCalls/AiProposeChangeToolCall/OperationRenderer.tsx

+
+type OperationRendererProps = {
+    operation: Operation;
+    fieldName: string;


from offline convo: call "property" instead of "field"/"fieldName" to avoid mixing other parts in the codebase mentioning field, which is usually a queryable object(dim,metric,tablecalc...)

graphite-app · 2025-10-02T11:33:46Z

packages/frontend/.storybook/preview.tsx

@@ -1,3 +1,5 @@
+import '@mantine-8/core/styles.css';


Import path violation: Replace '@mantine-8/core/styles.css' with the standard Mantine import path '@mantine/core/styles.css'. The frontend development guidelines require using standard Mantine import paths for the base UI library.

Suggested change

import '@mantine-8/core/styles.css';

import '@mantine/core/styles.css';

Spotted by Diamond (based on custom rule: packages/frontend rules)

Is this helpful? React 👍 or 👎 to let us know.

tatianainama · 2025-10-02T12:44:18Z

Merge activity

Oct 2, 12:44 PM UTC: A user started a stack merge that includes this pull request via Graphite.
Oct 2, 12:45 PM UTC: Graphite rebased this pull request as part of a merge.
Oct 2, 12:45 PM UTC: @tatianainama merged this pull request with Graphite.

# [0.2039.0](0.2038.1...0.2039.0) (2025-10-02) ### Features * introduce propose change tool template ([#17164](#17164)) ([9d63834](9d63834))

lightdash-bot · 2025-10-02T12:53:10Z

🎉 This PR is included in version 0.2039.0 🎉

The release is available on:

0.2039.0
GitHub release

Your semantic-release bot 📦🚀

tatianainama mentioned this pull request Oct 1, 2025

feat: add propose change tool validators #17163

Merged

lightdash-bot requested a deployment to pr-17164 October 1, 2025 13:46 Pending

tatianainama changed the base branch from 10-01-feat_add_propose_change_tool_validators to graphite-base/17164 October 1, 2025 14:33

tatianainama force-pushed the graphite-base/17164 branch from 042c480 to ea597d6 Compare October 1, 2025 14:33

tatianainama force-pushed the 10-01-feat_propose_change_tool_ui branch from c786248 to 7ac5b63 Compare October 1, 2025 14:33

graphite-app bot changed the base branch from graphite-base/17164 to main October 1, 2025 14:33

tatianainama force-pushed the 10-01-feat_propose_change_tool_ui branch from 7ac5b63 to 572d275 Compare October 1, 2025 14:34

lightdash-bot requested a deployment to pr-17164 October 1, 2025 14:34 Pending

tatianainama force-pushed the 10-01-feat_propose_change_tool_ui branch from 572d275 to 3b08a34 Compare October 1, 2025 15:04

lightdash-bot temporarily deployed to pr-17164 October 1, 2025 15:05 Inactive

tatianainama changed the title ~~feat: propose change tool ui~~ feat: introduce propose change tool template Oct 1, 2025

tatianainama force-pushed the 10-01-feat_propose_change_tool_ui branch from 3b08a34 to fa68e00 Compare October 2, 2025 07:40

lightdash-bot temporarily deployed to pr-17164 October 2, 2025 07:41 Inactive

tatianainama force-pushed the 10-01-feat_propose_change_tool_ui branch from fa68e00 to ea267a6 Compare October 2, 2025 08:41

tatianainama mentioned this pull request Oct 2, 2025

refactor: create ToolCallPaper component #17188

Merged

lightdash-bot requested a deployment to pr-17164 October 2, 2025 08:42 Pending

tatianainama force-pushed the 10-01-feat_propose_change_tool_ui branch from ea267a6 to 64388f8 Compare October 2, 2025 08:48

lightdash-bot requested a deployment to pr-17164 October 2, 2025 08:49 Pending

tatianainama force-pushed the 10-01-feat_propose_change_tool_ui branch from 64388f8 to 66b0a29 Compare October 2, 2025 08:50

tatianainama marked this pull request as ready for review October 2, 2025 08:50

graphite-app bot assigned tatianainama Oct 2, 2025

lightdash-bot deployed to pr-17164 October 2, 2025 08:50 View deployment

greptile-apps bot reviewed Oct 2, 2025

View reviewed changes

...ures/aiCopilot/components/ChatElements/ToolCalls/AiProposeChangeToolCall/SupportElements.tsx Show resolved Hide resolved

...ures/aiCopilot/components/ChatElements/ToolCalls/AiProposeChangeToolCall/SupportElements.tsx Outdated Show resolved Hide resolved

tatianainama requested a review from a team October 2, 2025 10:49

tatianainama force-pushed the 10-01-feat_propose_change_tool_ui branch from 66b0a29 to 83fa532 Compare October 2, 2025 11:01

lightdash-bot requested a deployment to pr-17164 October 2, 2025 11:02 Pending

joaoviana reviewed Oct 2, 2025

View reviewed changes

joaoviana approved these changes Oct 2, 2025

View reviewed changes

tatianainama force-pushed the 10-01-feat_propose_change_tool_ui branch from 83fa532 to 70b13af Compare October 2, 2025 11:32

lightdash-bot requested a deployment to pr-17164 October 2, 2025 11:33 Pending

graphite-app bot reviewed Oct 2, 2025

View reviewed changes

tatianainama force-pushed the 10-01-feat_propose_change_tool_ui branch from 70b13af to 7e48d98 Compare October 2, 2025 12:40

lightdash-bot requested a deployment to pr-17164 October 2, 2025 12:41 Pending

feat: propose change tool ui

ddf7b44

tatianainama force-pushed the 10-01-feat_propose_change_tool_ui branch from 7e48d98 to ddf7b44 Compare October 2, 2025 12:44

lightdash-bot requested a deployment to pr-17164 October 2, 2025 12:45 Pending

tatianainama merged commit 9d63834 into main Oct 2, 2025
8 of 10 checks passed

tatianainama deleted the 10-01-feat_propose_change_tool_ui branch October 2, 2025 12:45

lightdash-bot pushed a commit that referenced this pull request Oct 2, 2025

chore(release): 0.2039.0

238bc00

# [0.2039.0](0.2038.1...0.2039.0) (2025-10-02) ### Features * introduce propose change tool template ([#17164](#17164)) ([9d63834](9d63834))

lightdash-bot added the released label Oct 2, 2025

	import '@mantine-8/core/styles.css';
	import '@mantine/core/styles.css';

feat: introduce propose change tool template #17164

feat: introduce propose change tool template #17164

Uh oh!

Conversation

tatianainama commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Uh oh!

tatianainama commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 1, 2025

Uh oh!

github-actions bot commented Oct 1, 2025

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Sequence Diagram

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

joaoviana Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

joaoviana Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

joaoviana Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

graphite-app bot Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

tatianainama commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

lightdash-bot commented Oct 2, 2025

Uh oh!

Uh oh!

tatianainama commented Oct 1, 2025 •

edited

Loading

tatianainama commented Oct 1, 2025 •

edited

Loading

github-actions bot commented Oct 1, 2025 •

edited

Loading

tatianainama commented Oct 2, 2025 •

edited

Loading