Assure BroadcasterInterface packages of len > 1 are child-with-parents #4173
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @tnull as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4173 +/- ##
=======================================
Coverage 88.78% 88.79%
=======================================
Files 180 180
Lines 137066 137103 +37
Branches 137066 137103 +37
=======================================
+ Hits 121694 121738 +44
+ Misses 12552 12549 -3
+ Partials 2820 2816 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheBlueMatt
reviewed
Oct 24, 2025
| /// package and broadcast together. Some of the transactions may or may not depend on each other, | ||
| /// be sure to manage both cases correctly. | ||
| /// If more than one transaction is given, these transactions MUST be considered to be a | ||
| /// child-with-parents package and be broadcast together. Implementations MUST NOT |
There was a problem hiding this comment.
nit: might be worth clarifying a single child and linking the Bitcoin Core docs (if they're online or just saying "the submitpackage RPC").
Implementations MUST NOT assume any topological order on the transactions. While Bitcoin Core v29+ `submitpackage` RPC allows packages of length 1 to be submitted via `submitpackage`, it still requires any package submitted there to be a `child-with-parents` package. So we remove the possibility that a batch of transactions passed to a `BroadcasterInterface` implementation contains unrelated transactions, or multiple children.
tankyleo
force-pushed
the
25-10-broadcaster-docs
branch
from
4ba0e53 to
5916b2a
Compare
TheBlueMatt
reviewed
Oct 25, 2025
Comment on lines
+39
to
+40
| /// If more than one transaction is given, these transactions MUST be considered to be a | ||
| /// single-child-with-parents package and be broadcast together |
There was a problem hiding this comment.
Suggested change
| /// If more than one transaction is given, these transactions MUST be considered to be a | |
| /// single-child-with-parents package and be broadcast together | |
| /// If more than one transaction is given, these transactions MUST be a | |
| /// single child and its parents and be broadcast together as a package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementations MUST NOT assume any topological order on the transactions.
While Bitcoin Core v29+
submitpackageRPC allows packages of length 1 to be submitted viasubmitpackage, it still requires all packages submitted there to bechild-with-parents.So we remove the possibility that a batch of transactions passed to a
BroadcasterInterfaceimplementation contains unrelated transactions, or multiple children.