Skip to content

Conversation

@ViktorT-11
Copy link
Contributor

This PR prepares litd for the v0.15.3-alpha release, and bumps loop.

@gemini-code-assist
Copy link

Summary of Changes

Hello @ViktorT-11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on preparing the litd project for its v0.15.3-alpha release. This involves a significant update to the loop dependency, which in turn introduces several new fields and functionalities to the Loop In/Out swap RPCs. The changes enhance the flexibility and information provided during swap quoting and execution, particularly for static address loop-in swaps, and improve the notification system for better client recovery. Additionally, various other Go module dependencies have been updated to ensure the project uses the latest stable versions.

Highlights

  • Version Bump: The litd application version has been updated to v0.15.3-alpha.
  • Dependency Update: The loop dependency has been upgraded to v0.31.5-beta, bringing in new features and bug fixes from the Loop project.
  • API Enhancements for Loop Swaps: Several RPC messages related to Loop In/Out swaps have been extended. QuoteRequest now includes auto_select_deposits and fast flags, InQuoteResponse includes quoted_amt, Deposit includes swap_hash, and StaticAddressLoopInSwap, StaticAddressLoopInRequest, and StaticAddressLoopInResponse have new fields for deposits, amounts, change, and fast publication behavior.
  • Notification System Upgrade: The SubscribeNotificationsRequest now supports a ListenerVersion to allow for future notification protocol upgrades, and SubscribeNotificationsResponse can now include ServerUnfinishedSwapNotification to inform clients about incomplete swaps.
  • Documentation Update: The README.md file has been updated to reflect the new litd version and its corresponding integrated binary versions, and new release notes for v0.15.3 have been added.
  • Go Module Updates: Various Go module dependencies have been updated to their latest versions, including go.etcd.io/bbolt, golang.org/x/* packages, google.golang.org/protobuf, and several github.com/docker and opentelemetry related modules.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prepares for the v0.15.3-alpha release of litd. The changes primarily involve version bumps, updating dependencies, and adding new features to the Loop RPC interface. Specifically, new fields have been added to support 'fast' swaps and automatic deposit selection for loop-in swaps. The protobuf definitions, generated client code, and test data have been updated accordingly. The changes look good and are consistent with the goal of the PR. I've pointed out a couple of minor typos in the new RPC comments.

Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 🎉

ViktorT-11 and others added 10 commits October 31, 2025 18:12
Bumps [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) from 2.3.0 to 2.4.0.
- [Release notes](https://github.com/go-viper/mapstructure/releases)
- [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md)
- [Commits](go-viper/mapstructure@v2.3.0...v2.4.0)

---
updated-dependencies:
- dependency-name: github.com/go-viper/mapstructure/v2
  dependency-version: 2.4.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) from 2.3.0 to 2.4.0.
- [Release notes](https://github.com/go-viper/mapstructure/releases)
- [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md)
- [Commits](go-viper/mapstructure@v2.3.0...v2.4.0)

---
updated-dependencies:
- dependency-name: github.com/go-viper/mapstructure/v2
  dependency-version: 2.4.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) from 2.3.0 to 2.4.0.
- [Release notes](https://github.com/go-viper/mapstructure/releases)
- [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md)
- [Commits](go-viper/mapstructure@v2.3.0...v2.4.0)

---
updated-dependencies:
- dependency-name: github.com/go-viper/mapstructure/v2
  dependency-version: 2.4.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 2.1.3 to 2.1.4.
- [Commits](mafintosh/tar-fs@v2.1.3...v2.1.4)

---
updated-dependencies:
- dependency-name: tar-fs
  dependency-version: 2.1.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bump `loop` to `v0.31.5-beta`. We also bump `looprpc` to `v1.0.11` &
`swapserverrpc` to `v1.0.18` in order for `litd` to be compatible with
the new loop client.
As the new loop client is now ready for `lndclient` `v0.19.0-12`, we
also remove the previously added replace for `lndclient`.
@ViktorT-11
Copy link
Contributor Author

Fixed the "CI / check commits" error, by just adding a separate 010e550 commit. There's been no changes to the PR itself.

@levmi levmi requested a review from sputn1ck October 31, 2025 17:41
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 🚀

Tested the litd UI and TW e2e test suite. All clear from my end.

@ViktorT-11 ViktorT-11 merged commit dd92f49 into lightninglabs:litd_v0_15_3-alpha Oct 31, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants