config: exclude test files from TS build output #124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #123. I discovered an issue with the webpack build output. The
index.d.ts
file was being placed atdist/lib/index.d.ts
instead ofdist/index.d.ts
, which is what thepackage.json
defines as the entrypoint for types. This was because the TS test files, that were added in #123, were being included in the output. This is unnecessary and it causes errors when apps like Terminal import this package.The fix is pretty simple. We just need to exclude
*.test.ts
files from the build output.Before (wrong):

After (correct):

Steps to test
Just run
yarn build
and confirm that thedist/index.d.ts
file exists and there are no*.test.d.ts
files in thedist/
dir.