garbage collect zero-value UTXOs

[darioAnongba]

Garbage collect the residue orphaned UTXOs when creating transactions. Orphaned UTXOs occur when creating tombstones or full burns.
Currently, these UTXOs accumulate in the DB and are never cleaned. This PR introduces a garbage collection mechanism to collect these UTXOs and use them as inputs of transactions initiated by tapd:

• Transfers
• Burns

The PR adds a new swept flag to the managed_utxo table because UTXOs are not removed from the table when spent. This flag is also returned by the ListUtxos RPC endpoint.

The mechanism preserves the liveness and safety properties, ensuring that zero-value UTXOs can never accumulate in the DB. Adding garbage collection to Mint transactions is not necessary to ensure these properties.

Fixes #514

Note to reviewers

1. UTXO meaning unspent, keeping the spent outputs in a table called manage_utxos seems like a contradiction, same logic applies for the need of a swept flag in that table. We should either rename the table or store spent utxos somewhere else?

[coveralls]

Pull Request Test Coverage Report for Build 19245969484

Details

• 295 of 380 (77.63%) changed or added relevant lines in 16 files are covered.
• 83 unchanged lines in 20 files lost coverage.
• Overall coverage increased (+0.06%) to 56.582%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
asset/asset.go	3	5	60.0%
itest/assertions.go	0	3	0.0%
rpcserver.go	10	15	66.67%
tapfreighter/chain_porter.go	40	45	88.89%
tapfreighter/coin_select.go	23	29	79.31%
tapfreighter/wallet.go	55	76	72.37%
tapdb/assets_store.go	104	147	70.75%

Files with Coverage Reduction	New Missed Lines	%
proof/courier.go	1	79.81%
asset/asset.go	2	79.89%
lndservices/block_header_cache.go	2	97.52%
mssmt/compacted_tree.go	2	77.65%
tapdb/mssmt.go	2	90.45%
tapdb/multiverse.go	2	80.05%
tapdb/sqlc/transfers.sql.go	2	83.33%
taprpc/universerpc/universe_grpc.pb.go	2	65.45%
universe_rpc_diff.go	2	76.0%
universe/supplyverifier/manager.go	2	64.53%

Totals
Change from base Build 18942913401:	0.06%
Covered Lines:	64576
Relevant Lines:	114128

---

💛 - Coveralls

[darioAnongba]

I like SweepOrphanUtxos better as well. I renamed it everywhere at the config level, let me know if you think we should rename all the way down to the DB layer. In the context of assets, zero-value is correct though, but more verbose and uglier.

[GeorgeTsagk]

last nits, 99% there

[GeorgeTsagk]

LGTM

[lightninglabs-deploy]

@ffranr: review reminder

[ffranr]

Something for your consideration:

I’ve found that wrapping errors like this is usually enough:

fmt.Errorf("query chain assets at anchor: %w", err)

Since it will appear inside a higher level error anyway, adding “failed to” doesn’t add much in my view.

[darioAnongba]

I agree we should reduce verbosity as much as possible but I don't feel comfortable breaking the pattern of the rest of the codebase (we seem to use everywhere one of these):

• unable to ...
• error...
• failed to ...

Happy to work on a PR to reduce verbosity globally at some point.