-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Introduce ValidatorManager to track all requests and validators' scores #4752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
deuszx
wants to merge
32
commits into
testnet_conway
Choose a base branch
from
conway_validator-manager
base: testnet_conway
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,244
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f8be16f
to
b66d121
Compare
af2f10d
to
e2391e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Linera client needs to interact with multiple validator nodes efficiently. Previously, the
client would make individual requests to validators without:
bandwidth and validator resources
This led to:
Proposal
This PR introduces ValidatorManager, a sophisticated request orchestration layer that provides
intelligent peer selection, request deduplication, caching, and performance-based routing.
Key Features
contain the needed data (e.g., a request for blocks 10-12 can be satisfied by an in-flight request
for blocks 10-20)
attempts
Created a new
validator_manager
module with clear separation of concerns:API
High-level APIs:
Benefits
Metrics
In production usage, this should significantly reduce:
The following metrics have been added to Prometheus (with compiled with
--features metrics
):validator_manager_response_time_ms
- Response time for requests to validators in millisecondsvalidator_manager_request_total
- Total number of requests made to each validatorvalidator_manager_request_success
- Number of successful requests to each validator ((validator_manager_request_total - validator_manager_request_success) / validator_manager_request_total
is an error rate)validator_manager_request_deduplication_total
- Number of requests that were deduplicated by joining an in-flight requestvalidator_manager_request_cache_hit_total
- Number of requests that were served from cacheTest Plan
Existing CI makes sure we maintain backwards compatibility. Some tests have been added to the new modules.
Release Plan
Links