Thread latest certficiate for chain updates (#4963) #4990
Merged
+84
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When debugging Faucet performance we noticed that `communicate_with_quorum` takes significantly longer when sending chain updates (compared to submitting block proposals and validated certificates). Comparing the work being done between the calls, `send_chain_information` additionally has to load the latest hash from the `local_node.chain_state_view` (which is two async calls) and then read a certificate for it from the storage (another async call). Thread through the latest certificate if it's known and don't read it from the storage in `send_chain_information`. Tests are updated. - Should be deployed to testnet Faucet - Backport to `main`. - [reviewer checklist](https://github.com/linera-io/linera-protocol/blob/main/CONTRIBUTING.md#reviewer-checklist)
afck
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When debugging Faucet performance we noticed that
communicate_with_quorumtakes significantly longer when sending chain updates (compared to submitting block proposals and validated certificates). Comparing the work being done between the calls,send_chain_informationadditionally has to load the latest hash from thelocal_node.chain_state_view(which is two async calls) and then read a certificate for it from the storage (another async call).Proposal
Thread through the latest certificate if it's known and don't read it from the storage in
send_chain_information.Test Plan
Tests are updated.
Release Plan
Links