Skip to content

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Sep 12, 2025

Description 📝

part 2 of Linode Interface Network Section tests (see part 1 at #12842)

  • editing interfaces
  • editing interface settings
  • deleting an interface

Once part 1 gets merged in, I'll remove the hold on review label, rebase and then this PR's diff will shrink

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

n/a

Preview 📷

no visual changes

How to test 🧪

pnpm cy:run -s "cypress/e2e/core/linodes/linode-network.spec.ts"
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

bnussman-akamai
bnussman-akamai approved these changes Oct 8, 2025
@coliu-akamai coliu-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Oct 9, 2025
@coliu-akamai
Copy link
Contributor Author

currently having trouble getting CM to work locally - will look into the failing test once I figure that out

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 4 failing tests on test run #8 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
4 Failing840 Passing13 Skipped44m 40s

Details

Failing Tests
SpecTest
linode-network.spec.tsCloud Manager Cypress Tests→Linode Interfaces enabled→Linode with Linode-based interfaces→Editing a Linode Interface » confirms editing a VPC interface
create-database.spec.tsCloud Manager Cypress Tests→create a database cluster, mocked data » creates a g7-premium-4 MySQL v8.x 2-node cluster
create-firewall.spec.tsCloud Manager Cypress Tests→create firewall » "before all" hook for "creates a firewall without a linode"
create-firewall.spec.tsCloud Manager Cypress Tests→restricted user cannot create firewall » "before each" hook for "confirms the create button is disabled on the Firewall Landing page"

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/linode-network.spec.ts,cypress/e2e/core/databases/create-database.spec.ts,cypress/e2e/core/firewalls/create-firewall.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

3 participants