Skip to content

Conversation

@kagora-akamai
Copy link
Contributor

@kagora-akamai kagora-akamai commented Oct 1, 2025

Description 📝

Cypress e2e test for logs destinations

Changes 🔄

  • empty Destination Landing test
  • non-empty Destination Landing test
  • create Destination test
  • edit Destination test

Scope 🚢

  • No customers / Not applicable

Target release date 🗓️

October 2025

How to test 🧪

Prerequisites

Set up manager with devCloud credentials and add to manager/.env:

CYPRESS_BASE_URL='https://cloud.devcloud.linode.com'
MANAGER_OAUTH=[devCloud PAT]

Verification steps

  • start cypress in console with command pnpm cy:debug
  • choose browser (chrome)
  • find deliverysection with tests and proceed with lounching each of them
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@kagora-akamai
Copy link
Contributor Author

kagora-akamai commented Oct 1, 2025

The API for this test is on devCloud so far. I see that the e2e here in PR are launched with Prod API, so the tests will not pass. How can we handle that? Or do we need to wait until API endpoints are released to Prod to merge these tests?

@kagora-akamai kagora-akamai marked this pull request as ready for review October 1, 2025 10:17
@kagora-akamai kagora-akamai requested a review from a team as a code owner October 1, 2025 10:17
@kagora-akamai kagora-akamai added the e2e Indicates that a PR touches Cypress tests in some way label Oct 1, 2025
@kagora-akamai kagora-akamai force-pushed the feature/DPS-34824-add-cypress-tests-for-logs-destinations branch from 7d9e3ab to 1f5f999 Compare October 1, 2025 10:58
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to make small contributions in the future. This PR is too large and should be broken down to allow for easier reviews.

Additionally, one of the test you added is failing in the CI

@kagora-akamai
Copy link
Contributor Author

kagora-akamai commented Oct 3, 2025

Hello @abailly-akamai

Please try to make small contributions in the future. This PR is too large and should be broken down to allow for easier reviews.

11/21 files are just import path updates as I found missing export on our side and just added it here to not create separate PR for such change. If that's important, I can move these to some other PR thats not related to e2e tests.

There are really only 4 cypress tests and 5 files with some supporting methods/mock data added as actual changes.

Additionally, one of the test you added is failing in the CI

Please check out the comment above (#12936 (comment)), as I explain why the test fails and ask for help with handling that issue.

@jdamore-linode jdamore-linode self-requested a review October 6, 2025 15:07
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kagora-akamai, this is a nice start and it's cool being able to see this feature in action!

The API for this test is on devCloud so far. I see that the e2e here in PR are launched with Prod API, so the tests will not pass. How can we handle that? Or do we need to wait until API endpoints are released to Prod to merge these tests?

Generally we mock API responses for endpoints that aren't available in Prod. I don't think it'd be too challenging to use mocks for create-destination.spec.ts and edit-destinaton.spec.ts to get them passing in CI if that's compatible with your requirements: it looks like you've already laid a lot of the groundwork by adding the necessary utils, etc.

Alternatively we can always set up a tag for tests like this so they get skipped when running against Prod but not DevCloud, but that'd require a (quick and easy) change to our CI pipeline first. I think it'd be worthwhile to have anyway so I'll get to work on that.

Let me know if you have any questions or if I can lend a hand!

@kagora-akamai kagora-akamai requested a review from a team as a code owner October 9, 2025 11:22
@kagora-akamai kagora-akamai requested review from dmcintyr-akamai and removed request for a team October 9, 2025 11:22
@kagora-akamai
Copy link
Contributor Author

kagora-akamai commented Oct 9, 2025

waiting for changes from task [DPS-35019] - Region field will be removed

@kagora-akamai kagora-akamai force-pushed the feature/DPS-34824-add-cypress-tests-for-logs-destinations branch from e97fdbd to 1640efd Compare October 20, 2025 07:11
@kagora-akamai kagora-akamai force-pushed the feature/DPS-34824-add-cypress-tests-for-logs-destinations branch from 1640efd to d37d1ee Compare October 20, 2025 08:33
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 3 failing tests on test run #7 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
3 Failing843 Passing13 Skipped41m 43s

Details

Failing Tests
SpecTest
object-storage.e2e.spec.tsCloud Manager Cypress Tests→object storage end-to-end tests » "before all" hook for "can create and delete object storage buckets"
object-storage-objects-multicluster.spec.tsCloud Manager Cypress Tests→Object Storage Multicluster objects » "before all" hook for "can upload, access, and delete objects"
access-key.e2e.spec.tsCloud Manager Cypress Tests→object storage access key end-to-end tests » "before all" hook for "can create an access key with unlimited access - e2e"

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts,cypress/e2e/core/objectStorage/access-key.e2e.spec.ts"

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kagora-akamai, this looks great and the tests pass reliably 👍

@kagora-akamai kagora-akamai added the Add'tl Approval Needed Waiting on another approval! label Oct 20, 2025
@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Oct 21, 2025
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 21, 2025
@mduda-akamai mduda-akamai merged commit 38e5b76 into linode:develop Oct 22, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! e2e Indicates that a PR touches Cypress tests in some way Logs

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

6 participants