Skip to content

Conversation

harsh-akamai
Copy link
Contributor

Description πŸ“

Create a boolean feature flag for Private Image Sharing and support it in Cloud

Changes πŸ”„

  • Private Image Sharing feature flag toggle added to our dev tool

Scope 🚒

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

How to test πŸ§ͺ

Verification steps

(How to verify changes)

  • Confirm a toggle for "Private Image Sharing" is present in our dev tool
  • (optional) Filter network requests for "LaunchDarkly" and observe the presence of a "privateImageSharing" object that has a false value
image
Author Checklists

As an Author, to speed up the review process, I considered πŸ€”

πŸ‘€ Doing a self review
❔ Our contribution guidelines
🀏 Splitting feature into small PRs
βž• Adding a changeset
πŸ§ͺ Providing/improving test coverage
πŸ” Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
πŸ‘£ Providing comprehensive reproduction steps
πŸ“‘ Providing or updating our documentation
πŸ•› Scheduling a pair reviewing session
πŸ“± Providing mobile support
β™Ώ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed βœ…

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Oct 21, 2025
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! Images Relating to Images labels Oct 21, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

πŸ”Ί 1 failing test on test run #3 β†—οΈŽ

❌ Failingβœ… Passingβ†ͺ️ SkippedπŸ• Duration
1 Failing847 Passing11 Skipped45m 31s

Details

Failing Tests
SpecTest
❌timerange-verification.spec.tsCloud Manager Cypress Testsβ†’Integration tests for verifying Cloudpulse custom and preset configurations Β» should implement and validate custom date/time picker for a specific date and time range

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/cloudpulse/timerange-verification.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Images Relating to Images

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

6 participants