Skip to content

Conversation

@kagora-akamai
Copy link
Contributor

@kagora-akamai kagora-akamai commented Oct 20, 2025

Description 📝

Bug fix for confirmation dialog for Destination delete action. Error state did not reset when modal Canceled and reopened for different destination.

Changes 🔄

  • Error state for destination delete confirmation modal resets on open action
  • Same change applied for stream delete confirmation modal.

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • No customers / Not applicable

Target release date 🗓️

November 2025

Preview 📷

Before After
Screenshot 2025-10-20 at 13 43 14 Screenshot 2025-10-20 at 13 45 46
Screenshot 2025-10-20 at 13 45 54 Screenshot 2025-10-20 at 13 43 30

How to test 🧪

Prerequisites

  • start manager with Mock CRUD enabled

  • navigate to /logs/delivery/destinations

  • create 2 Destinations

  • navigate to Streams tab and create a stream using one of the existing destinations

Reproduction steps

  • navigate to /logs/delivery/destinations
  • open Menu Action next to Destination used in Stream, click on Delete, click on Delete in modal
  • error should appear that Destination is used in Stream and cannot be deleted; Cancel modal
  • open Menu Action next to the other Destination, click on Delete
  • confirmation modal will open and error from previous action will be visible - incorrect behavior

Verification steps

  • navigate to /logs/delivery/destinations
  • open Menu Action next to Destination used in Stream, click on Delete, click on Delete in modal
  • error should appear that Destination is used in Stream and cannot be deleted; Cancel modal
  • open Menu Action next to the other Destination, click on Delete
  • confirmation modal will open without error from previous action - correct behavior
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
📱 Providing mobile support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@kagora-akamai kagora-akamai marked this pull request as ready for review October 20, 2025 12:12
@kagora-akamai kagora-akamai requested a review from a team as a code owner October 20, 2025 12:12
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 7 failing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
7 Failing832 Passing13 Skipped51m 18s

Details

Failing Tests
SpecTest
object-storage-objects-multicluster.spec.tsCloud Manager Cypress Tests→Object Storage Multicluster objects » "before all" hook for "can upload, access, and delete objects"
access-key.e2e.spec.tsCloud Manager Cypress Tests→object storage access key end-to-end tests » "before all" hook for "can create an access key with unlimited access - e2e"
vm-host-maintenance-linode.spec.tsCloud Manager Cypress Tests→Host & VM maintenance notification banner » maintenance notification banner on landing page for 1 linode
vm-host-maintenance-linode.spec.tsCloud Manager Cypress Tests→Host & VM maintenance notification banner » maintenance notification banner on landing page for >1 linodes
vm-host-maintenance-linode.spec.tsCloud Manager Cypress Tests→Host & VM maintenance notification banner » banner present on details page when linode has pending maintenance
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page
object-storage.e2e.spec.tsCloud Manager Cypress Tests→object storage end-to-end tests » "before all" hook for "can create and delete object storage buckets"

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts,cypress/e2e/core/objectStorage/access-key.e2e.spec.ts,cypress/e2e/core/linodes/vm-host-maintenance-linode.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts"

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ✅
Verification steps ✅

@kagora-akamai kagora-akamai added the Add'tl Approval Needed Waiting on another approval! label Oct 22, 2025
@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Oct 27, 2025
@mikeZuber-akamai mikeZuber-akamai merged commit 75abf52 into linode:develop Oct 27, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Add'tl Approval Needed Waiting on another approval! Logs

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

5 participants