WIP: Add support for ML-DSA PQC keys #19
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanberger
force-pushed
the
mldsa
branch
7 times, most recently
from
1a1ad73 to
b04726b
Compare
stefanberger
force-pushed
the
mldsa
branch
8 times, most recently
from
80459bf to
37929f9
Compare
Disable the following warning to be able to keep the name in a printf string as other functions already do. WARNING: Prefer using '"%s...", __func__' to using 'sign_hash_v1', this function's name, in a string Signed-off-by: Stefan Berger <[email protected]>
In the imaevm_signhash API, replace the unsized sig parameter array with an expected pointer to an array sig[MAX_SIGNATURE_SIZE - 1]. This conversion at least enforces the correct size for the array for the imaevm_signhash call inside evmctl.c as well as another known user of the library, namely the rpmsign tool. Signed-off-by: Stefan Berger <[email protected]>
To overcome the limitations of imaevm_signhash API call, implement imaevm_signhash2 that takes a pointer to a buffer pointer for the signature and therefore allows the called function to allocate a buffer. Allocate a buffer if the user provided no buffer or a buffer that is smaller than MAX_SIGNATURE_SIZE - 1. Signed-off-by: Stefan Berger <[email protected]>
OpenSSL >= v3.5.0 supports signing with ML-DSA-44/65/87. Add support for it to the library. Since the ML-DSA signatures require a lot more space for the signature now, increase the size of the array where the signatures are stored. The following are the sizes of ML-DSA signatures by key type: - ML-DSA-44: 2420 - ML-DSA-65: 3309 - ML-DSA-87: 4627 The size of extended attributes may be smaller than what is required by the ML-DSA signature size, and therefore may not be possible to store for example ML-DSA-87 signatures. Nevertheless, extend the MAX_SIGNATURE_SIZE to the required size of ML-DSA-87 and display an error if writing the signature of a size larger than 4k did not work. Since IMA in the kernel hashes all files before verifying the signature against the hash, we have to use ML-DSA in pre-hash mode. For this, support the sha-2 family of hashes that are also supported on the evcmtl command line using '-a'. Signed-off-by: Stefan Berger <[email protected]>
Create mldsa-44 & mldsa-65 keys if mldsa44 can be created with the installed version of OpenSSL. Add test cases for signing and verifying with these types of keys. Do not test with mldsa-87 keys since the signatures they create may be too large for some filesystems' xattrs. On btrfs, however, it is possible to store their large signatures. Signed-off-by: Stefan Berger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series adds support for ML-DSA PQC key support to the library and evmctl and adds test cases for signing and verifying to the sign_verfiy.test. It requires availability of OpenSSL 3.5.