Bodies of if and loop statements should be inside braces #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just merged rt-link support, please rebase and regenerate the sources. |
Summary: readability-braces-around-statements requires bodies of if and loop statements should be inside braces current generated code doesn't follow this requirement for single line blocks https://clang.llvm.org/extra/clang-tidy/checks/readability/braces-around-statements.html Test Plan: regenerate code to make sure missing braces are added Signed-off-by: Sheldon Wu <[email protected]>
sheldnwu
force-pushed
the
fix_miss_braces
branch
from
a04c924 to
2cb0603
Compare
Signed-off-by: Sheldon Wu <[email protected]>
sheldnwu
force-pushed
the
fix_miss_braces
branch
from
2cb0603 to
2f4bdba
Compare
|
rebase done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
readability-braces-around-statements requires bodies of if and loop statements should be inside braces current generated code doesn't follow this requirement for single line blocks
https://clang.llvm.org/extra/clang-tidy/checks/readability/braces-around-statements.html
Test Plan:
regenerate code to make sure missing braces are added