You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.
The lsiown command explicitly avoids touching symlinks, allowing root
owned symlinks to bleed into PUID/PGID controlled areas.
Use the chown arguments when using rsync to copy files to /data and
/config to prevent creating symlinks with root permissions.
Signed-off-by: Randolph Sapp <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StaticRocket
force-pushed
the
rsync-chown
branch
from
Description:
The lsiown command explicitly avoids touching symlinks, allowing root owned symlinks to bleed into PUID/PGID controlled areas.
Use the chown arguments when using rsync to copy files to /data and /config to prevent creating symlinks with root permissions.
Benefits of this PR and context:
Prevents creating symlinks as root, which the fpm or host user will not be able to remove/replace as needed.
How Has This Been Tested?
I used the modified commands to remove existing invalid symlinks from my deployment.
Source / References:
N/A