update(ui): redesign lesson card component #1004
Open
+150
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galalqassas
force-pushed
the
galal/redesign-lesson-card-component
branch
from
51b1e33 to
fc60c8c
Compare
galalqassas
force-pushed
the
galal/redesign-lesson-card-component
branch
from
fc60c8c to
c1aa29f
Compare
mmoehabb
requested changes
Sep 16, 2025
galalqassas
force-pushed
the
galal/redesign-lesson-card-component
branch
from
c1aa29f to
b7205c8
Compare
galalqassas
force-pushed
the
galal/redesign-lesson-card-component
branch
from
b7205c8 to
3802386
Compare
mmoehabb
requested changes
Sep 28, 2025
Comment on lines
+177
to
+178
| topics: range(7).map(() => faker.lorem.words(1)), | ||
| level: "C1", |
There was a problem hiding this comment.
There is no English level for tutors. This should only appear in students cards for tutors.
Furthermore, lesson-card for students is different from lesson-card for tutors.
There was a problem hiding this comment.
You better write this in LessonCardV2 for instance.
| <Typography | ||
| key="remaining" | ||
| tag="span" | ||
| className="border border-natural-500 rounded-[200px] px-1.5 py-1" |
There was a problem hiding this comment.
specify the text color, size, and width to match the prototype.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quality Checklist
Links
Important
Incase you have any valuable knowledge that you think that it is worth writing down, feel free to add it to our handbook. Wounder why we are doing this? check this guide.