update(web): update student settings page design #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moalidv
force-pushed
the
mo/settings-info-tab
branch
from
8c329ef to
ba49849
Compare
mmoehabb
requested changes
Sep 16, 2025
packages/ui/src/locales/ar-eg.json
Outdated
| "tutor-settings.topics.selection-dialog.title": "شارك خبراتك لتجذب الطلاب الذين يشاركونك الشغف!", | ||
| "tutor-settings.topics.selection-dialog.description": "حدد المجالات التي تبرع فيها أو تهتم بها، مثل الرياضة أو التكنولوجيا أو علم النفس، لنساعدك في تخصيص تجربة تدريسية تناسب اهتمامات طلابك وتزيد من تفاعلهم وحماسهم للتعلم.", | ||
| "student-settings.add-topics-button.label": "قم بأضافة الموضوعات المفضلة الخاصة بك", | ||
| "student-settings.updated-successfully": "تم تحديث بيانانك بنجاح", |
There was a problem hiding this comment.
"تم تحديث بياناتك بنجاح."
Comment on lines
70
to
73
| topics: [], | ||
| career: "", | ||
| level: IStudent.EnglishLevel.Beginner, | ||
| aim: "", |
There was a problem hiding this comment.
The defaults should be the actual student data.
Write mock hooks if you needed to.
There was a problem hiding this comment.
This is how it looks on Galaxy S10:
- Try to make the tabs view more responsive.
- The font referred to in the screenshot is quite big.
moalidv
force-pushed
the
mo/settings-info-tab
branch
4 times, most recently
from
1178d02 to
f829bad
Compare
moalidv
force-pushed
the
mo/settings-info-tab
branch
from
f829bad to
0a9cbd3
Compare
moalidv
force-pushed
the
mo/settings-info-tab
branch
2 times, most recently
from
8aa855b to
30692e4
Compare
mmoehabb
requested changes
Sep 18, 2025
packages/headless/src/student.ts
Outdated
Comment on lines
94
to
125
| const levelValues = Object.values(IStudent.EnglishLevel).filter( | ||
| (value) => typeof value === "number" | ||
| ); | ||
|
|
||
| function getRandomLevel() { | ||
| const randomLevel = sample(levelValues); | ||
| return randomLevel as IStudent.EnglishLevel; | ||
| } | ||
|
|
||
| export function useStudentMeta(): UseQueryResult<{ | ||
| career: string; | ||
| level: IStudent.EnglishLevel; | ||
| aim: string; | ||
| }> { | ||
| const find = useCallback(async () => { | ||
| return { | ||
| career: sample([ | ||
| "labels.jobs.student", | ||
| "labels.jobs.tutor", | ||
| "labels.jobs.doctor", | ||
| "labels.jobs.police-officer", | ||
| ]), | ||
| level: getRandomLevel(), | ||
| aim: "labels.random-aim", | ||
| }; | ||
| }, []); | ||
|
|
||
| return useQuery({ | ||
| queryFn: find, | ||
| queryKey: ["find-student-meta"], | ||
| }); | ||
| } |
There was a problem hiding this comment.
First of all... no need for randomness for these mock functions/hooks. Second, I don't think we need to mock this.
You can just implement it as the mocking part falls on the server responsibility.
export function useFindStudentById(id): UseQueryResult<IStudent.FindApiResponse> {
const api = useApi();
const find = useCallback(async () => {
return api.student.findById(...);
}, [api.student]);
return useQuery({
queryFn: find,
queryKey: ["find-student-by-id"],
});
}
moalidv
force-pushed
the
mo/settings-info-tab
branch
3 times, most recently
from
1d51e4f to
6afcef8
Compare
mmoehabb
requested changes
Sep 22, 2025
packages/headless/src/student.ts
Outdated
|
|
||
| return useQuery({ | ||
| queryFn: find, | ||
| queryKey: ["find-student-by-id"], |
packages/headless/src/topic.ts
Outdated
|
|
||
| return useMutation({ | ||
| mutationFn: update, | ||
| mutationKey: ["update-user-topics"], |
| const form = useForm<IForm>({ | ||
| defaults: { | ||
| topics: studentTopics.data || [], | ||
| career: studentData?.jobTitle || intl("labels.jobs.student"), |
There was a problem hiding this comment.
or empty string is better. Don't force values or auto-fill user inputs.
There was a problem hiding this comment.
Great work so far.
It requires more effort from us in order to make it more user friendly. As shown in the attached screenshot. There is no enough spaces between the buttons.
We may make it more responsive by breaking the label into two lines when the width gets this small. WDYT?
moalidv
force-pushed
the
mo/settings-info-tab
branch
from
6afcef8 to
d1c9746
Compare
moalidv
force-pushed
the
mo/settings-info-tab
branch
from
d1c9746 to
aabd992
Compare
moalidv
force-pushed
the
mo/settings-info-tab
branch
from
aabd992 to
50687f2
Compare
mmoehabb
requested changes
Sep 24, 2025
moalidv
force-pushed
the
mo/settings-info-tab
branch
from
50687f2 to
133b2f8
Compare
mmoehabb
force-pushed
the
mo/settings-info-tab
branch
from
133b2f8 to
dbaff00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quality Checklist
Links
Important
Incase you have any valuable knowledge that you think that it is worth writing down, feel free to add it to our handbook. Wounder why we are doing this? check this guide.