feat: added conversion api implementation #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostafakamar2308
force-pushed
the
mk/pixel
branch
from
0744919 to
cb23bff
Compare
mmoehabb
requested changes
Jun 10, 2025
apps/landing/lib/analytics.ts
Outdated
| }: { | ||
| page: string; | ||
| fbclid?: string | null; | ||
| eventName: IAnalytics.EventType; |
There was a problem hiding this comment.
Let's stick with either name: event-name or event-type.
mostafakamar2308
force-pushed
the
mk/pixel
branch
from
cb23bff to
5fcb846
Compare
mostafakamar2308
force-pushed
the
mk/pixel
branch
from
5fcb846 to
6588d13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quality Checklist
Links