Skip to content

Krisp example #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Krisp example #47

wants to merge 5 commits into from

Conversation

hiroshihorie
Copy link
Collaborator

No description provided.

bcherry
bcherry reviewed Aug 20, 2024
View reviewed changes
Shared/Controllers/AppContext.swift

#if os(iOS)
// Krisp noise filter example
lazy var krispProcessor = LiveKitKrispNoiseFilter()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiroshihorie can we add ObservableObject to LiveKitKrispNoiseFilter so it can be passed in @EnvironmentObject? That would be a more intuitive way to integrate into SwiftUI

bcherry
bcherry requested changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@bcherry bcherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should leave Krisp out of the shared example, since it's a paid feature only available to cloud scale and enterprise customers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcherry bcherry bcherry requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiroshihorie @bcherry