Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions .github/workflows/api-changes.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
name: Detect Public API changes

on:
workflow_dispatch:
push:
branches: [main]
pull_request:
branches: [main]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
build:
runs-on: macos-15
timeout-minutes: 30

steps:
- uses: actions/checkout@v4

- name: Define Diff Versions
run: |
NEW="${{ env.source }}~${{ env.headGithubRepo }}"
OLD="${{ env.target }}~${{ env.baseGithubRepo }}"

if [[ '${{ env.targetBranchName || env.noTargetBranch }}' == release/* ]]
then
LATEST_TAG=$(git describe --tags --abbrev=0)
OLD="$LATEST_TAG~${{ env.baseGithubRepo }}"
fi

# Providing the output to the environment
echo "OLD_VERSION=$OLD" >> $GITHUB_ENV
echo "NEW_VERSION=$NEW" >> $GITHUB_ENV
env:
source: "${{ github.event.inputs.new || github.head_ref }}"
target: "${{ github.event.inputs.old || github.event.pull_request.base.ref }}"
headGithubRepo: "${{github.server_url}}/${{ github.event.pull_request.head.repo.full_name || github.repository}}.git"
baseGithubRepo: "${{github.server_url}}/${{github.repository}}.git"
noTargetBranch: "no target branch"
targetBranchName: "${{ github.head_ref }}"

# The github action automatically posts on a PR (if it's not a fork-PR)
# and/or outputs the diff to the $GITHUB_STEP_SUMMARY
- name: Detect Changes
uses: Adyen/[email protected]
with:
platform: "iOS"
new: ${{ env.NEW_VERSION }}
old: ${{ env.OLD_VERSION }}
4 changes: 2 additions & 2 deletions Sources/LiveKit/Core/Room.swift
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@
public var serverRegion: String? { _state.serverInfo?.region.nilIfEmpty }

/// Region code the client is currently connected to.
@objc
public var serverNodeId: String? { _state.serverInfo?.nodeID.nilIfEmpty }
// @objc
// public var serverNodeId: String? { _state.serverInfo?.nodeID.nilIfEmpty }

@objc
public var remoteParticipants: [Participant.Identity: RemoteParticipant] { _state.remoteParticipants }
Expand Down Expand Up @@ -199,7 +199,7 @@
// log sdk & os versions
log("sdk: \(LiveKitSDK.version), os: \(String(describing: Utils.os()))(\(Utils.osVersionString())), modelId: \(String(describing: Utils.modelIdentifier() ?? "unknown"))")

signalClient._delegate.set(delegate: self)

Check warning on line 202 in Sources/LiveKit/Core/Room.swift

View workflow job for this annotation

GitHub Actions / test (macos-15, 16.2, iOS Simulator,OS=18.1,name=iPhone 16 Pro)

actor-isolated property '_delegate' can not be referenced from a nonisolated context; this is an error in the Swift 6 language mode

log()

Expand Down
Loading