Skip to content

Text/byte stream handling bug, documentation issues #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Text/byte stream handling bug, documentation issues #379

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d87b54a
Fix for text/byte streams
onorabil Mar 1, 2025
b032586
original call signature
onorabil Mar 1, 2025
8f955c5
CI fix attempt 0
onorabil Mar 1, 2025
1e19e11
CI fix attempt 1
onorabil Mar 1, 2025
8d170a6
CI fix attempt 2
onorabil Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions livekit-rtc/livekit/rtc/room.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import ctypes
import logging
from dataclasses import dataclass, field
from typing import Callable, Dict, Literal, Optional, cast, Mapping
from typing import Callable, Dict, Literal, Optional, cast, Mapping, Any

from .event_emitter import EventEmitter
from ._ffi_client import FfiClient, FfiHandle
Expand Down Expand Up @@ -753,7 +753,11 @@ def _handle_stream_header(

text_reader = TextStreamReader(header)
self._text_stream_readers[header.stream_id] = text_reader
text_stream_handler(text_reader, participant_identity)
task: asyncio.Task[Any] = asyncio.create_task(
text_stream_handler(text_reader, participant_identity) # type: ignore
)
self._data_stream_tasks.add(task)
task.add_done_callback(self._data_stream_tasks.discard)
elif stream_type == "byte_header":
byte_stream_handler = self._byte_stream_handlers.get(header.topic)
if byte_stream_handler is None:
Expand All @@ -765,7 +769,11 @@ def _handle_stream_header(

byte_reader = ByteStreamReader(header)
self._byte_stream_readers[header.stream_id] = byte_reader
byte_stream_handler(byte_reader, participant_identity)
task = asyncio.create_task(
byte_stream_handler(byte_reader, participant_identity) # type: ignore
)
self._data_stream_tasks.add(task)
task.add_done_callback(self._data_stream_tasks.discard)
else:
logging.warning("received unknown header type, %s", stream_type)
pass
Expand Down
Loading