Ensure the treasury automatically resumes once balance < cap #646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Ensures the treasury automatically resumes instead of setting the cut to 0% once the cap is reached. This way, it will continue accumulating as the balance depletes.
Wondering if this can be a good solution instead of raising the cap.
Note that this will cause an emitted
ParameterUpdate
event for thetreasuryRewardCutRate
after each round it flips below/above the cap.This change does not affect the subgraph, as that is not updated to take the treasury into account at all at the moment.
Specific updates (required)
nextRoundTreasuryRewardCutRate
when the cap is reached.How did you test each of these updates (required)
N/A
Does this pull request close any open issues?
N/A
Checklist:
yarn test
pass