Skip to content

Conversation

stronk-dev
Copy link

@stronk-dev stronk-dev commented Apr 2, 2025

What does this pull request do? Explain your changes. (required)
Ensures the treasury automatically resumes instead of setting the cut to 0% once the cap is reached. This way, it will continue accumulating as the balance depletes.

Wondering if this can be a good solution instead of raising the cap.
Note that this will cause an emitted ParameterUpdate event for the treasuryRewardCutRate after each round it flips below/above the cap.
This change does not affect the subgraph, as that is not updated to take the treasury into account at all at the moment.

Specific updates (required)

  • Removes logic in reward calls which modifies nextRoundTreasuryRewardCutRate when the cap is reached.
  • Modify Round init to set the cut for the current round only to 0 for as long as the cap is reached.

How did you test each of these updates (required)
N/A

Does this pull request close any open issues?
N/A

Checklist:

  • README and other documentation updated
  • All tests using yarn test pass

@stronk-dev stronk-dev force-pushed the feature/TreasuryAutoResume branch from 44481e4 to e55109a Compare April 2, 2025 14:50
@stronk-dev
Copy link
Author

Tests need updating for this as well.

@stronk-dev stronk-dev force-pushed the feature/TreasuryAutoResume branch from e55109a to 7a8e38c Compare April 2, 2025 14:57
@stronk-dev stronk-dev force-pushed the feature/TreasuryAutoResume branch from 7a8e38c to f5fa1f6 Compare April 2, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant