Skip to content

feat: enhance golangci-lint configuration for better code quality #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: enhance golangci-lint configuration for better code quality #367

wants to merge 3 commits into from

Conversation

@rishi-jat
Copy link

Summary

  • Add 10+ new high-value linters focusing on security, k8s patterns, and code quality
  • Enhanced error handling with errorlint, nilerr for robust controller code
  • Added security linters: gosec, bodyclose, contextcheck, noctx
  • Improved import organization with gci for large project maintainability
  • Added character safety checks: asciicheck, bidichk
  • Enhanced testing support with testpackage for Ginkgo conventions
  • Strategically disabled overly restrictive linters (varnamelen, exhaustruct, etc.)
  • Added comprehensive documentation and ROI analysis
  • Maintains compatibility with existing codebase while improving standards

Fixes #149

@rishi-jat rishi-jat mentioned this pull request Oct 4, 2025
Open
@elevran elevran moved this to In review in llm-d-inference-scheduler Oct 19, 2025
elevran
elevran requested changes Oct 20, 2025
View reviewed changes
Copy link
Collaborator

@elevran elevran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishi-jat thanks for the PR.
A few points that are required in order to start moving it forward:

  • DCO is required
  • rebasing is required
  • while helpful for PR review, the markdown files are not part of the configuration change and should not be included in the PR.
  • CI should pass (currently fails)
  • lint configuration file is missing a newline at end of file.

In addition, we'll review the list of added/modified linters` configuration so can reach consensus on specific linters ROI (e.g., false positive rates...)

@elevran elevran moved this from In review to In progress in llm-d-inference-scheduler Oct 20, 2025
@rishi-jat rishi-jat force-pushed the enhance/golangci-lint-configuration branch from f32c095 to 33cbde7 Compare October 21, 2025 08:49
@elevran
Copy link
Collaborator

elevran commented Oct 24, 2025 •
edited
Loading

@rishi-jat please address previous review comments (DCO, remove extra files in commit).
If you're unsure about a specific ask, let me know and I can help you address that.

@rishi-jat
Copy link
Author

Apologies, For late will do all the suggested changes today! Thanks

@rishi-jat rishi-jat force-pushed the enhance/golangci-lint-configuration branch 3 times, most recently from fffc431 to 8c41d39 Compare October 25, 2025 22:39
@elevran
Copy link
Collaborator

elevran commented Oct 26, 2025

thanks for removing the extra files.
The PR fails lint and test (invalid/missing version?) and that should be fixed.
Once that's fixed, we can merge and later fine-tune if needed (e.g., there might be overlap, gocritic tends to be too opinionated unless tuned, etc.)

@rishi-jat
feat: enhance golangci-lint configuration for better code quality
0b021fc 
- Add 10+ new high-value linters focusing on security, k8s patterns, and code quality
- Enhanced error handling with errorlint, nilerr for robust controller code
- Added security linters: gosec, bodyclose, contextcheck, noctx
- Improved import organization with gci for large project maintainability
- Added character safety checks: asciicheck, bidichk
- Enhanced testing support with testpackage for Ginkgo conventions
- Strategically disabled overly restrictive linters (varnamelen, exhaustruct, etc.)
- Maintains compatibility with existing codebase while improving standards

Fixes llm-d#149

Signed-off-by: Rishi Jat <[email protected]>
@rishi-jat rishi-jat force-pushed the enhance/golangci-lint-configuration branch from 8c41d39 to 0b021fc Compare October 28, 2025 17:43
@rishi-jat
Merge branch 'main' into enhance/golangci-lint-configuration
24462a7
@rishi-jat
fix: address golangci-lint configuration issues
2a03593 
- Remove deprecated gomnd linter
- Add newline at end of file
- Add exclusion rules for problematic packages
- Configuration now works with modern golangci-lint versions

Fixes golangci-lint compatibility and CI issues.

Signed-off-by: Rishi Jat <[email protected]>
@rishi-jat
Copy link
Author

@elevran I have fix the lint error and also can you please add Hacktoberfestt tag as this pr is part of my Hacktoberfest contribution!
image

@elevran
Copy link
Collaborator

elevran commented Oct 31, 2025 •
edited
Loading

what is an Hacktoberfest tag?
It's not an existing label we have. Is llm-d-inference-scheduler repo signed up for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elevran elevran elevran requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

llm-d-inference-scheduler
Status: In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Review (and expand, if needed) golangci-lint configuration

2 participants

@rishi-jat @elevran