Allow the sidecar to sample from a list of prefill host ports #404
+125
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarterclayton
force-pushed
the
enable_sampling
branch
from
c97d980 to
d4d1e8d
Compare
In some benchmarking and test environments dynamic prefill selection may be difficult and random selection among a set of hosts is sufficient. Add a new `--enable-prefiller-sampling` flag that instructs the sidecar to select a random prefill host from the provided list instead of the first one. Make the behavior opt-in to prevent users from accidentally depending on the new behavior, and keep the existing default behavior (first header value) consistent. E.g.: curl -H 'x-prefiller-host-port: server1:8000` -H 'x-prefiller-host-port: server2:8000' will randomly choose one of the two values. Signed-off-by: Clayton Coleman <[email protected]>
smarterclayton
force-pushed
the
enable_sampling
branch
from
d4d1e8d to
f67ae2c
Compare
shmuelk
requested changes
Oct 30, 2025
| expectedPrefillerIn []string | ||
| expectedPassthrough bool | ||
| }{ | ||
| {r: &http.Request{}, expectedPassthrough: true}, |
There was a problem hiding this comment.
Please fill in the name field in each of the tests. Also print the name field in any error messages. That way we know which test failed.
| func TestServer_chatCompletionsHandler(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| port string |
There was a problem hiding this comment.
As you never use the port field and don't really need it, please delete it from the struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some benchmarking and test environments dynamic prefill selection
may be difficult and random selection among a set of hosts is
sufficient.
Add a new
--enable-prefiller-samplingflag that instructs thesidecar to select a random prefill host from the provided list
instead of the first one. Make the behavior opt-in to prevent
users from accidentally depending on the new behavior, and
keep the existing default behavior (first header value) consistent.
E.g.:
curl -H 'x-prefiller-host-port: server1:8000` -H 'x-prefiller-host-port: server2:8000'
will randomly choose one of the two values.
Moved from the original repo