Add a vimeo/youtube embed function that supports private and public endpoints #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pete Cheslock <[email protected]>
Signed-off-by: Pete Cheslock <[email protected]>
✅ Deploy Preview for elaborate-kangaroo-25e1ee ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
petecheslock
changed the title
…chitecture documentation; add VideoEmbed component for responsive YouTube video embedding. Signed-off-by: Pete Cheslock <[email protected]>
|
We've got a YouTube account setup for the project now. I've moved the full presentation and architecture video over to YT as an unlisted video. I've split the video into 2 parts (overview/demo) and those are public on YT. Here is the updated code to support youtube only embedding. |
petecheslock
changed the title
|
@jjasghar If you have any time, can you review this. It's honestly pretty straight forward addition of a component to embed youtube videos - now that we have that channel setup - we can hos content there. |
jjasghar
approved these changes
Jun 24, 2025
petecheslock
added a commit
to petecheslock/llm-d.github.io
that referenced
this pull request
Jun 25, 2025
…ndpoints (llm-d#48) * Add a VimeoEmbed component to embed public or private vimeo videos Signed-off-by: Pete Cheslock <[email protected]> * Add video demonstration section to architecture documentation Signed-off-by: Pete Cheslock <[email protected]> * Replace VimeoEmbed component with VideoEmbed for YouTube videos in architecture documentation; add VideoEmbed component for responsive YouTube video embedding. Signed-off-by: Pete Cheslock <[email protected]> --------- Signed-off-by: Pete Cheslock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.