Skip to content

Conversation

rafasumi
Copy link
Contributor

Implemented missing feature for issue #1793. Also implemented LLVM lowering for the hot attribute, and added a new test case.

@rafasumi rafasumi changed the title [CIR] Attach hot attribute to CIR function [CIR][CodeGen] Attach hot attribute to CIR function Aug 15, 2025
Copy link
Collaborator

@tommymcm tommymcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nits

Also, if you didn't already, try using mlir/utils/generate_test_checks.py to generate test checks automatically with a uniform format.

Copy link
Collaborator

@tommymcm tommymcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
If you can revert those formatting changes it would be appreciated. I try to only format the code regions that I change to avoid getting myself in the blame chain :^)

@rafasumi
Copy link
Contributor Author

Hey @bcardosolopes. Will you run CI checks for this PR again now that the issues with clang-tidy were fixed (I think)?

@bcardosolopes
Copy link
Member

Hey @bcardosolopes. Will you run CI checks for this PR again now that the issues with clang-tidy were fixed (I think)?

Sure, once you land the first PR these will be triggered automatically!

@bcardosolopes bcardosolopes merged commit bd25483 into llvm:main Aug 27, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants