[CIR][CodeGen] Implemented VisitTypeTraitExpr #1850
Merged
+37
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijeetsharma200
requested review from
lanza,
bcardosolopes,
xlauko and
andykaylor
as code owners
tommymcm
reviewed
Aug 22, 2025
xlauko
reviewed
Aug 22, 2025
tommymcm
reviewed
Aug 22, 2025
tommymcm
reviewed
Aug 22, 2025
tommymcm
reviewed
Aug 22, 2025
|
Hey, I was going through the code reviews of other PRs and saw the discussion on the use of auto. Thus, changed my code to have explicit types. |
bcardosolopes
approved these changes
Aug 25, 2025
|
Thanks everyone for the reviews and guidance 🙏 my first PR for CIR, learned a lot! Hopefully the first of many to come. Do I need to do anything for the merge or will a maintainer handle it? |
You're welcome, thank you for the contribution! No worries I'll merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Issue #1802