Skip to content

Conversation

badumbatish
Copy link
Contributor

Hi there, I'm opening the PR to add syntax highlighting support for vim and neovim users.

The PR borrows a lot from MLIR but also add

  • Dedicated CIR types like bytes
  • Dedicated CIR keywords(?!) like coroutine, resume, suspend, etc etc.
  • Blanket operation highlighting for CIR operations (No need to edit syntax/cir.vim again for new operations)

Below is the before and after of applying syntax highlighting.

Before:
Screenshot 2025-08-22 at 3 30 44 PM

After:
Screenshot 2025-08-22 at 3 30 21 PM

@badumbatish
Copy link
Contributor Author

@AmrDeveloper you might like this

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for caring about these things!
LGTM, happy when @AmrDeveloper approves this. Also if you'd like to add some docs to clangir.org it's just one PR away in the gh-pages branch!

@badumbatish
Copy link
Contributor Author

i forgot to add CIR: to highlighting before pushing, will do this later

Copy link
Member

@AmrDeveloper AmrDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the syntax file. I have some suggestions, and later we can update the file when we have a new keyword

Copy link
Member

@AmrDeveloper AmrDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@badumbatish
Copy link
Contributor Author

thanks Amr for the reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants