[CIR] Implement virtual destructor call #1856
Open
+42
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedshakill
requested review from
lanza,
bcardosolopes,
xlauko and
andykaylor
as code owners
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
tommymcm
reviewed
Aug 25, 2025
clang/test/CIR/CodeGen/virtual-destructor-explicit-unqualified-call.cpp
Outdated
Show resolved
Hide resolved
clang/test/CIR/CodeGen/virtual-destructor-explicit-unqualified-call.cpp
Outdated
Show resolved
Hide resolved
tommymcm
reviewed
Aug 25, 2025
clang/test/CIR/CodeGen/virtual-destructor-explicit-unqualified-call.cpp
Outdated
Show resolved
Hide resolved
clang/test/CIR/CodeGen/virtual-destructor-explicit-unqualified-call.cpp
Outdated
Show resolved
Hide resolved
bcardosolopes
approved these changes
Aug 25, 2025
bcardosolopes
requested changes
Aug 26, 2025
|
|
||
| QualType thisTy = | ||
| IsArrow ? Base->getType()->getPointeeType() : Base->getType(); | ||
| emitCXXDestructorCall(globalDecl, callee, This.getPointer(), thisTy, |
There was a problem hiding this comment.
I see some code repetition from the else part, that can be improved overall
There was a problem hiding this comment.
Classic codegen, calls CGM.getCXXABI().EmitVirtualDestructorCall() here. Is there a reason we can't do that?
| // CIR-NEXT: %[[DTOR:.*]] = cir.load align(8) %[[DTOR_PTR]] : !cir.ptr<!cir.ptr<!cir.func<(!cir.ptr<!rec_A>)>>>, !cir.ptr<!cir.func<(!cir.ptr<!rec_A>)>> | ||
| // CIR-NEXT: cir.call %[[DTOR]](%[[THIS]]) : (!cir.ptr<!cir.func<(!cir.ptr<!rec_A>)>>, !cir.ptr<!rec_A>) -> () | ||
| // CIR-NEXT: cir.trap | ||
| // CIR-NEXT: } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1812