[NFC] Update flags for portability #359
Open
+61
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates all the tests that rely on nan-preservation to pass `-Gis` which ensures NaN preservation. Any of the tests that are touched in this PR which also test literal values which could be constant evaluated also should use `-HV 202x` to have consistent literal types, so that change is also made to a few test cases. Fixes llvm#348
I removed the denorm cases from the sinh test (denorms are wildly varried in how they are handled and I don't think we can assume sane handling across platforms). I also reverted my changes to the frac tests since for some reason that's causing problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all the tests that rely on nan-preservation to pass
-Giswhich ensures NaN preservation. Any of the tests that are touched in this PR which also test literal values which could be constant evaluated also should use-HV 202xto have consistent literal types, so that change is also made to a few test cases.Fixes #348