Enable fixed-size resource array tests for Clang #364
+22
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm-beanz
approved these changes
Aug 20, 2025
|
Woo! |
…o enable-fixes-size-res-array-tests
It is not needed since none of them is using a struct.
…m/hekota/offload-test-suite into enable-fixes-size-res-array-tests
inbelic
approved these changes
Aug 22, 2025
bogner
approved these changes
Aug 22, 2025
Comment on lines
54
to
55
| # XFAIL: DXC && DirectX-WARP | ||
| # XFAIL: Clang && DirectX-WARP |
There was a problem hiding this comment.
Would it make more sense to just have one XFAIL: DirectX-WARP line here? Similarly for intel below.
…ntel Temporarily enabling this test to get the data needed to file an issue.
…data needed to file an issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the support for fixed-size resource array has been implemented in Clang, these tests are now passing.
Also removing -fvk-use-scalar-layout flag from the tests as they did not really need it (none of them are using structs).
Related to llvm/llvm-project#133835.