adds ckeditor stylesheet to subtheme generator #883
Conversation
|
Haven't tested the actual commit, but having employed the same changes in my local subtheme, I can report that the method is sound, so LGTM. |
tonypaulbarker
left a comment
tonypaulbarker
left a comment
There was a problem hiding this comment.
Left some thoughts on the code comment guidance for use cases and examples.
| @@ -0,0 +1,17 @@ | |||
| /* | |||
| @file CKEditor styles. | |||
| These styles are applied within the CKEditor 5 interface to | |||
There was a problem hiding this comment.
I think the guidance here should be to use sparingly, for cases where the editor could not otherwise tell how the content would be formatted (like style plug ins). The CKEditor window is not meant to match the front end (fonts, colours, spacing and so on) and making it match in some ways but not others can cause confusion. One example of a case is that heading colours may be different for different sections of the site. A suggestion would be to include a real example from the base theme file again here instead of the heading colours.
I think that linters might complain about a file with only comments?
| base theme: "localgov_base" | ||
| ckeditor5-stylesheets: | ||
| # List any stylesheets you want to apply to the CKEditor | ||
| # interface here. This allows you to match your content editing |
There was a problem hiding this comment.
See review comments on scripts/subtheme-items/css/base/ckeditor5.css , applies here too.
Closes #882
Thanks to Big Blue Door for sponsoring my time to work on this.