GEOMESA-3435. mention scylladb in docs #3255
Conversation
|
Thanks for adding the docs! I don't think we should replace all mentions of Cassandra with Cassandra/ScyllaDB - how about adding a new |
mkorolyov
force-pushed
the
GEOMESA-3435-add-scylladb-to-docs
branch
from
392150f to
6675d5a
Compare
|
changes look reasonable to me, but the build is failing. @jnh5y do you have any comments? |
|
@elahrvivaz Hey, build fixed, could you pls take a look one more time? |
|
@mkorolyov thanks for adding the test containers; it is a huge help to be able to test things over time! @elahrvivaz The changes look reasonable to me. As soon as we get a green build, I'd say it is good to go. I kicked off the build... I see some codacy things failed; I don't understand it. |
| <version>1.20.4</version> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
| <version>1.20.4</version> | |
| <scope>test</scope> |
we can leave these out since they're defined in the main pom dependency management. Do we need 1.20.4? currently we're on 1.20.3 - it's fine to bump it, we'd just want to do it in the main pom.
There was a problem hiding this comment.
updated in the main pom to 1.20.6(the latest one) We need 1.20.5+ to recently added ScyllaDB Container support in java test containers
| cassandraContainer.start() | ||
| scyllaContainer.start() |
There was a problem hiding this comment.
tests are failing to connect to the container - i think you'd have to add exposed ports for 9042 here, and then use container.getMappedPort(9042) in the data store params
There was a problem hiding this comment.
i've migrated from Generic container where we need to handle such things explicitly to CassandraContainer and ScyllaDBContainer, which handles such things out of the box. Could you pls retry the tests?
...atastore/src/test/scala/org/locationtech/geomesa/cassandra/data/CassandraDataStoreTest.scala
Outdated
Show resolved
Hide resolved
|
the codacy failure just needed a retry, and the dash failures are b/c i opened some eclipse tickets that are in an "open" unresolved state, so no worries there. |
mkorolyov
force-pushed
the
GEOMESA-3435-add-scylladb-to-docs
branch
from
168d7ce to
07b0818
Compare
…dd scylladb support to docs
mkorolyov
force-pushed
the
GEOMESA-3435-add-scylladb-to-docs
branch
from
07b0818 to
5a3c128
Compare
| params = Map( | ||
| Params.ContactPointParam.getName -> s"$host:$port", | ||
| val params = Map( | ||
| Params.ContactPointParam.getName -> s"${container.getHost}:9042", |
There was a problem hiding this comment.
i think you're still going to need container.getMappedPort(0942) (syntax might be wrong...) here and above, otherwise both containers are going to conflict on that port.
ScyllaDB is a drop in more performant replacement for Cassandra. It works out of the box with GeoMesa just by replacing connection string from Cassandra to ScyllaDB. Lets mention this in docs so people will be aware of such option.