Skip to content

Conversation

khaefeli
Copy link
Contributor

@khaefeli khaefeli commented Jan 3, 2018

#35 allow setting the user id over the resource.
and workaround the issue with empty usernames & the default anonymous user (be careful here!)

@logicminds
Copy link
Owner

Thanks for the flurry of PRs. I'll need to update the travis file unless you can fix the .travis in a new PR. Also since these changes require Facter with structured facts we need to communicate that in the readme and metadata file. We should be targeting Puppet 4.x+ anyways. Please create a CHANGELOG.md and CONTRIBUTORS.md. Add your fixes to Changelog and throw your name/email in the CONTRIBUTORS file.

@khaefeli
Copy link
Contributor Author

khaefeli commented Jan 4, 2018

I've updated the .travis.yml and removed the ruby 1.9.3 support.
tests are running now, but many errors ;)

I can create the changelog and contributors files, should we target v 1.0 and support Puppet 4.x+ without or without older versions?

@logicminds
Copy link
Owner

Please target a 1.0 release

@logicminds
Copy link
Owner

We can also target ruby 2.1.9 and ruby 2.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants