Skip to content

fix kafka client_id. remove thread idxnum #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix kafka client_id. remove thread idxnum #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3bac7cd
fix kafka client_id. remove thread idxnum
Nov 2, 2018
7adc397
fix kafka client_id. remove thread idxnum
raistlinzx Nov 2, 2018
70c45dd
Merge branch 'master' of https://github.com/raistlinzx/logstash-input…
raistlinzx Nov 2, 2018
312dcf4
fix spec
raistlinzx Nov 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/logstash/inputs/kafka.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ def register

public
def run(logstash_queue)
@runner_consumers = consumer_threads.times.map { |i| create_consumer("#{client_id}-#{i}") }
@runner_consumers = consumer_threads.times.map { |i| create_consumer(client_id) }
@runner_threads = @runner_consumers.map { |consumer| thread_runner(logstash_queue, consumer) }
@runner_threads.each { |t| t.join }
end # def run
Expand Down
2 changes: 1 addition & 1 deletion spec/integration/inputs/kafka_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def thread_it(kafka_input, queue)
wait(timeout_seconds).for {queue.length}.to eq(num_events)
expect(queue.length).to eq(num_events)
kafka_input.kafka_consumers.each_with_index do |consumer, i|
expect(consumer.metrics.keys.first.tags["client-id"]).to eq("spec-#{i}")
expect(consumer.metrics.keys.first.tags["client-id"]).to eq("spec")
end
ensure
t.kill
Expand Down