SparkSample #2
Open
SparkSample #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob: Please take a look at the comments/changes in: - VisualBasicViewCompilerTester.cs - SubViewFolderTester.cs
…nto ahjohannessen-mono-spike
- Added dependency NUnit.Analyser v3 so that we can convert the Classic Assert to Constraint Model syntax - Added missing teardowns (enforced by NUnit.Analyser) - Used "dotnet format ./Spark.Xxx.Tests.csproj --severity info -v diag --exclude-diagnostics IDE0130" to upgrade the syntax - Some other minor formatting discrepancies have been fixed
- Upgrade remainder of old assert syntax to new one
- Updated various Microsoft dependencies
Updated copyright dates
- DefaultSyntaxProvider and DefaultBindingProver should not be registered as singleton services
- Added package info to Spark.AspNetCore.Mvc.csproj
…ents No longer leaking memory
Release github action
- Removed version tags from projects that do not produce nuget packages
- Hopefully this will fixed the missing web targets build error
- Reverted to using dotnet pack with a slnf file - Removed hardcoded references to Microsft.Webapplication.targets in Spark.JsTests.csproj
- Unit tests already run for each commit in ci.yml
…kage name on nuget.org
…ting Spark.Web package on nuget.org
…-weblib Renamed Spark.Web project to Spark.WebLib
Updated dependencies
- NUnit - Microsoft.Extensions.Caching.Memory - System.Configuration.ConfigurationManager - Bumped version to 1.8.2.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.