Skip to content

Conversation

eigerx
Copy link
Contributor

@eigerx eigerx commented Apr 9, 2025

No description provided.

config:
# Alert distribution only runnable in PP environment.
alertPackager.doProduceAlerts: True
config.astrometry.referenceSelector.doUnresolved: False
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the leading config. necessary?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that the leading config. should not be there, but more importantly this is a config for calibrateImage not diaPipe. So to set this you would need to exclude calibrateImage from ApPipe.yaml above and redefine it here, along with all of it's custom connections and configs.

Copy link
Member

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major change: the config is for calibrateImage not diaPipe

config:
# Alert distribution only runnable in PP environment.
alertPackager.doProduceAlerts: True
config.astrometry.referenceSelector.doUnresolved: False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that the leading config. should not be there, but more importantly this is a config for calibrateImage not diaPipe. So to set this you would need to exclude calibrateImage from ApPipe.yaml above and redefine it here, along with all of it's custom connections and configs.

@kfindeisen
Copy link
Member

Is this PR still relevant? I thought it was a workaround for Pipelines issues.

@kfindeisen
Copy link
Member

Is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants