DM-51311: Prompt Processing hangs on certain operations #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that activator.py is an importable module, and not an executable, it should list the members intended to be imported elsewhere.
The GracefulShutdownInterrupt and generic error handlers were identical except for one line. It's easier (if slightly slower?) to use an explicit isinstance check than to maintain two different handlers.
This lets the worker be called with a timeout, with the timeout's implementation details hidden from process_visit's clients.
It is possible (but unlikely) that the execution framework can fail in a way that's impossible to recover from, and prevents processing any more visits. This case is now handled correctly by the driver.
The timeout uses a ProcessPoolExecutor that's kept alive as long as possible, and rebooted if it starts raising BrokenProcessPool. Unfortunately, the fact that the two standard pools *can* break leaks out of the process_visit implementation despite attempts to handle it internally.
kfindeisen
force-pushed
the
tickets/DM-51311
branch
from
12f856e to
9df10fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests various ways to interrupt Prompt Processing on a timer.