[Revert] Fabric windows implementation #849
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otikbiswas100/react-native-config into fabric-windows-implementation
|
I tested this build on both iOS and Android with success. |
|
Tested on 0.81.1. |
|
@luancurti please merge the build. and release a new version |
|
@luancurti any updates on this? This fixes the Android build failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
added fabric support for windows, Fabric is the new architecture of react native
Why this change is needed
People using this library should be able to use the new architecture of react native
Testing
Added TurboModule enable flag via react-native.config.js. Wrote a minimal test to assert exported Config object and fallback logic.
Attached image of unit testing