proc_fuse: fix proc_stat_read reporting host cpu count under cgroup v2 #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@last-las can you edit your commit message to include the required Signed-off-by line? (see CONTRIBUTING.md) |
Signed-off-by: Quanjin Lin <[email protected]>
last-las
force-pushed
the
fix-proc-stat-read
branch
from
6fccfda to
255b7a7
Compare
done! |
|
@mihalicyn can you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cgroup v2 doesn't have a file similar to
cpuacct.usage_all. Therefore, theproc_stat_readin cgroup v2 always falls back to the host's /proc/stat. As a result, the CPU count reported by this file is incorrect, e.g. issues #593 and #654.However, the similar
proc_cpuinfo_readfunction does report the right CPU counts. It works by filtering the host's file using bothcpuset.cpusandcpu.max. This patch fixesproc_stat_readby using the same method.