Implement support for user flag to run within root context #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this idea, but I will hopefully get clearance to upload our go package that drops down to the current user when run as root (we actually run this with a binary built on that at Airbnb). I’ll leave this open for a while on the off chance I don’t get approval to open source what we’ve written. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to set the default browser within a root context like when automating deployment of a new Mac. Most of my onboarding tools run as root already, and though I could run as a user,
default-browserdoesn't currently have support for anything other than Go's built inCurrentUser. This PR adds--useras an optional flag when running as root/sudo. When--useris provided the launch services plist for that user is modified.com.apple.launchservices.secure.plistby getting the user's home dir, and not assuming/Users/$username.