Add support for CMS 6 #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satrun77
force-pushed
the
pulls/cms6-support
branch
2 times, most recently
from
92f94e1 to
df4fc12
Compare
src/FieldType/EncryptedDatetime.php
Outdated
| { | ||
| parent::__construct($name, $options); | ||
| // disable date validation to allow for empty value | ||
| self::config()->set('field_validators', []); |
There was a problem hiding this comment.
You shouldn't alter config at runtime if you can avoid it. Use this instead:
private static array $field_validators = [
// Remove parent validator
DatetimeFieldValidator::class => null,
];Better would be to introduce new appropriate validation but I'll let someone who's doing a real review decide if they care about that - I'm just doing a driveby.
Collaborator
Author
There was a problem hiding this comment.
Thanks 🙏 I was trying to remove the validation or change it but could not figure out how!
satrun77
force-pushed
the
pulls/cms6-support
branch
from
df4fc12 to
1e482d0
Compare
satrun77
force-pushed
the
pulls/cms6-support
branch
from
1e482d0 to
dfbd24c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests pass. Not tested yet, but we are in the process of testing this in the coming weeks