Mark Metal as automatically safe #790
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
metal-is-safe
branch
from
cd95060 to
c494477
Compare
MarijnS95
commented
Sep 29, 2025
| unsafe-default-safety.instance-methods = true | ||
| unsafe-default-safety.class-methods = true | ||
| unsafe-default-safety.functions = true | ||
| unsafe-default-safety.not-bounds-affecting = true |
There was a problem hiding this comment.
Really need to doublecheck this, it has a bunch of false-positives such as when setting buffer named index_buffer 😅
|
Sorry, I actually also worked on this just today, so we kinda raced on this. I'll close this in favour of #792, but thanks anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #773 #774