Skip to content

Conversation

Thirumalbalu
Copy link

Description (*)

Added a conditional statement to avoid potential performance issue while loading active shipping methods.

Fixed Issues (if relevant)

  1. Fixes Potential performance issue on loading shipping methods #40153

Manual testing scenarios (*)

  1. Doesn't impact OOB magento, can be merged as long as the automated MFTF test cases are pass.

Questions or comments

  1. OOB magento doesn't trigger the function with argument true however it's going to be useful for customers who extends or leverage this for their business specific usage.
  2. Helps to avoid creating performance issues during customization.

Copy link

m2-assistant bot commented Aug 25, 2025

Hi @Thirumalbalu. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@ct-prd-pr-scan
Copy link

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected].

@Thirumalbalu
Copy link
Author

@magento run Unit Tests

@Thirumalbalu
Copy link
Author

@magento run all tests

@ct-prd-pr-scan
Copy link

The security team has been informed about this pull request due to the presence of risky security keywords. For security vulnerability reports, please visit Adobe's vulnerability disclosure program on HackerOne or email [email protected].

@engcom-Hotel engcom-Hotel added Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Aug 26, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Status: Pending Review
Development

Successfully merging this pull request may close these issues.

Potential performance issue on loading shipping methods
2 participants